Fix MarshalJSON error caused by incorrect conversion function #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2302 +/- ##
==========================================
+ Coverage 62.05% 62.06% +0.01%
==========================================
Files 277 278 +1
Lines 21588 21589 +1
==========================================
+ Hits 13396 13400 +4
+ Misses 6792 6788 -4
- Partials 1400 1401 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
controlplane.Service couldn't be converted to v1beta1.Service directly as it has an extra field. This patch fixes it by using the auto-generated conversion function. Signed-off-by: Quan Tian <[email protected]>
tnqn
changed the title
|
/test-all |
antoninbas
approved these changes
Jun 24, 2021
Actually looks like it's explained by #2305 :) |
abhiraut
approved these changes
Jun 24, 2021
This was referenced Jun 25, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
controlplane.Service couldn't be converted to v1beta1.Service directly as it has an extra field. This patch fixes it by using the auto-generated conversion function.
Signed-off-by: Quan Tian [email protected]
Fixes #2303
It may need to be backported to 0.13, 1.0, and 1.1.