Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #2317: Fix ovs group id conflict when dual stack is enabled #2322

Conversation

hongliangl
Copy link
Contributor

Cherry pick of #2317 on release-1.0.

#2317: Fix ovs group id conflict when dual stack is enabled

For details on the cherry pick process, see the cherry pick requests page.

When dual stack is enabled, there will be IPv4 and IPv6 AntreaProxy. The IPv4
AntreaProxy and IPv6 AntreaProxy don't share the same GroupCounter. When a
IPv6 Service is created by IPv6 AntreaProxy, the GroupID generated may be
duplicated with a GroupID used by IPv4 Service. GroupCounter of IPv6
AntreaProxy can start with 0x10000000 to avoid above issue.

Signed-off-by: Hongliang Liu <[email protected]>
@hongliangl hongliangl added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Jun 29, 2021
@tnqn
Copy link
Member

tnqn commented Jun 29, 2021

/test-all

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2021

Codecov Report

Merging #2322 (fba128c) into release-1.0 (e8bf52d) will decrease coverage by 4.14%.
The diff coverage is 60.00%.

❗ Current head fba128c differs from pull request most recent head 0a9824e. Consider uploading reports for the commit 0a9824e to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.0    #2322      +/-   ##
===============================================
- Coverage        61.07%   56.92%   -4.15%     
===============================================
  Files              272      266       -6     
  Lines            20404    19604     -800     
===============================================
- Hits             12462    11160    -1302     
- Misses            6645     7070     +425     
- Partials          1297     1374      +77     
Flag Coverage Δ
e2e-tests 56.92% <60.00%> (?)
kind-e2e-tests ?
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/proxy/types/groupcounter.go 87.50% <50.00%> (-7.74%) ⬇️
pkg/agent/proxy/proxier.go 64.55% <100.00%> (+0.94%) ⬆️
pkg/controller/networkpolicy/endpoint_querier.go 2.85% <0.00%> (-88.58%) ⬇️
pkg/controller/egress/controller.go 0.00% <0.00%> (-83.88%) ⬇️
pkg/apis/controlplane/v1beta1/conversion.go 1.20% <0.00%> (-83.14%) ⬇️
pkg/agent/util/iptables/lock.go 0.00% <0.00%> (-81.82%) ⬇️
...kg/agent/flowexporter/connections/conntrack_ovs.go 0.00% <0.00%> (-77.02%) ⬇️
pkg/cni/client.go 0.00% <0.00%> (-75.52%) ⬇️
pkg/apiserver/handlers/endpoint/handler.go 0.00% <0.00%> (-70.59%) ⬇️
pkg/agent/util/ethtool/ethtool_linux.go 0.00% <0.00%> (-70.00%) ⬇️
... and 109 more

@tnqn tnqn merged commit b0596b5 into antrea-io:release-1.0 Jun 29, 2021
@hongliangl hongliangl deleted the automated-cherry-pick-of-#2317-upstream-release-1.0 branch April 21, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants