[CI]Generate ssh-config for all Nodes #2675

xliuxu · 2021-08-30T06:33:44Z

WireGuard kernel module is present on IPv6 and IPv6 dual-stack clusters. Make sure that we can run commands on all nodes to check for kernel modules. This is a prerequisite for WireGuard e2e tests.
The error is as follows:

=== RUN   TestWireGuard
    fixtures.go:95: The following modules have been found on Node 'antrea-ipv6-9-0': [wireguard]
    fixtures.go:89: Skipping test as modprobe could not be run to confirm the presence of module 'wireguard': unable to find 'HostName' for 'antrea-ipv6-9-1' in SSH config
--- SKIP: TestWireGuard (0.81s)

Fixes #2661

Signed-off-by: Xu Liu [email protected]

xliuxu · 2021-08-30T06:34:42Z

/test-ipv6-only-e2e
/test-ipv6-ds-e2e
/test-ipv6-e2e
/test-e2e

codecov-commenter · 2021-08-30T06:41:31Z

Codecov Report

Merging #2675 (ed03eaa) into main (d8d70ac) will decrease coverage by 1.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2675      +/-   ##
==========================================
- Coverage   60.70%   59.52%   -1.19%     
==========================================
  Files         285      285              
  Lines       23003    23020      +17     
==========================================
- Hits        13965    13702     -263     
- Misses       7544     7867     +323     
+ Partials     1494     1451      -43

Flag	Coverage Δ
kind-e2e-tests	`46.76% <ø> (-1.61%)`	⬇️
unit-tests	`41.03% <ø> (-0.05%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...g/agent/apiserver/handlers/featuregates/handler.go	`0.00% <0.00%> (-82.36%)`	⬇️
...kg/apiserver/registry/system/supportbundle/rest.go	`19.54% <0.00%> (-55.18%)`	⬇️
pkg/support/dump_others.go	`0.00% <0.00%> (-51.73%)`	⬇️
pkg/support/dump.go	`8.13% <0.00%> (-49.60%)`	⬇️
...g/agent/apiserver/handlers/addressgroup/handler.go	`0.00% <0.00%> (-40.00%)`	⬇️
...agent/apiserver/handlers/appliedtogroup/handler.go	`0.00% <0.00%> (-40.00%)`	⬇️
pkg/apiserver/handlers/loglevel/handler.go	`0.00% <0.00%> (-38.47%)`	⬇️
pkg/ovs/ovsctl/ofctl.go	`18.51% <0.00%> (-19.76%)`	⬇️
pkg/ovs/ovsctl/appctl.go	`32.60% <0.00%> (-11.96%)`	⬇️
pkg/log/log_level.go	`0.00% <0.00%> (-10.00%)`	⬇️
... and 19 more

xliuxu · 2021-08-30T11:18:49Z

/test-ipv6-only-e2e
/test-ipv6-ds-e2e
/test-ipv6-e2e

xliuxu · 2021-08-30T11:23:52Z

/test-ipv6-only-e2e

xliuxu · 2021-08-30T11:33:23Z

/test-ipv6-only-e2e
/test-ipv6-ds-e2e
/test-ipv6-e2e

xliuxu · 2021-08-30T13:01:07Z

/test-ipv6-only-e2e

xliuxu · 2021-08-30T13:42:06Z

/test-all
/test-ipv6-ds-e2e
/test-ipv6-e2e

xliuxu · 2021-08-31T02:42:48Z

/test-all
/test-ipv6-only-e2e
/test-ipv6-ds-e2e
/test-ipv6-e2e

lzhecheng · 2021-08-31T09:03:13Z

It is possible to define a function to reuse ssh-config generation code in run_e2e and run_e2e_windows?

xliuxu · 2021-08-31T13:02:46Z

/test-all
/test-ipv6-only-e2e
/test-ipv6-ds-e2e
/test-ipv6-e2e
/test-windows-e2e

xliuxu · 2021-09-01T01:26:02Z

/test-windows-e2e
/test-e2e

lzhecheng · 2021-09-01T01:45:15Z

A suggestion: this PR doesn't touch test-vmc.sh so there's no need to run VMC Jenkins jobs (test-e2e, test-conformance, test-networkpolicy).

xliuxu · 2021-09-01T02:15:11Z

A suggestion: this PR doesn't touch test-vmc.sh so there's no need to run VMC Jenkins jobs (test-e2e, test-conformance, test-networkpolicy).

Thanks for pointing it out.

I think WireGuard e2e tests passed on IPv6 and IPv6 dual-stack clusters.

=== RUN   TestWireGuard
    fixtures.go:95: The following modules have been found on Node 'antrea-ipv6-9-0': [wireguard]
    fixtures.go:95: The following modules have been found on Node 'antrea-ipv6-9-1': [wireguard]
    fixtures.go:95: The following modules have been found on Node 'antrea-ipv6-9-2': [wireguard]
    fixtures.go:182: Creating 'antrea-test' K8s Namespace
2021-08-31 14:31:04.447889 I | Applying Antrea YAML
2021-08-31 14:31:07.077809 I | Waiting for all Antrea DaemonSet Pods
2021-08-31 14:31:08.087017 I | Checking CoreDNS deployment
=== RUN   TestWireGuard/testWireGuardTunnelConnectivity
    connectivity_test.go:76: Waiting for Pods to be ready and retrieving IPs
    connectivity_test.go:86: Retrieved all Pod IPs: map[connectivity-testdifferentnodes-2jlhn:IPv4(10.244.1.85),IPv6(2001:db8:42:2::17e4),IPstrings(10.244.1.85,2001:db8:42:2::17e4) connectivity-testdifferentnodes-8k7cn:IPv4(10.244.0.41),IPv6(2001:db8:42::29),IPstrings(10.244.0.41,2001:db8:42::29)]
    connectivity_test.go:95: Ping mesh test between all Pods
    connectivity_test.go:104: Ping 'connectivity-testdifferentnodes-2jlhn' -> 'connectivity-testdifferentnodes-8k7cn': OK
    connectivity_test.go:104: Ping 'connectivity-testdifferentnodes-8k7cn' -> 'connectivity-testdifferentnodes-2jlhn': OK
=== CONT  TestWireGuard
    fixtures.go:384: Deleting 'antrea-test' K8s Namespace
--- PASS: TestWireGuard (95.26s)
    --- PASS: TestWireGuard/testWireGuardTunnelConnectivity (23.44s)

xliuxu · 2021-09-01T10:48:44Z

/test-ipv6-only-e2e
/test-ipv6-ds-e2e
/test-ipv6-e2e
/test-windows-e2e

xliuxu · 2021-09-01T13:18:32Z

/test-ipv6-only-e2e
/test-ipv6-ds-e2e
/test-ipv6-e2e
/test-windows-e2e

lzhecheng · 2021-09-02T03:15:06Z

/test-windows-e2e

ci/jenkins/test.sh

lzhecheng · 2021-09-02T04:00:24Z

/test-windows-e2e

Make sure we can check kernel modules on all Nodes in the cluster. This is a prerequisite for WireGuard e2e tests. Fixes: antrea-io#2661 Signed-off-by: Xu Liu <[email protected]>

xliuxu · 2021-09-02T14:09:09Z

/test-ipv6-only-e2e
/test-ipv6-ds-e2e
/test-ipv6-e2e
/test-windows-e2e

tnqn

LGTM

tnqn · 2021-09-02T15:10:25Z

/skip-all

tnqn · 2021-09-02T15:28:33Z

The required kind test failed on the known flaky AntreaPolicy tests #2394:

--- FAIL: TestAntreaPolicy/TestGroupNoK8sNP/Case=ACNPClusterGroupEgressRulePodsAToCGWithNsZ (15.60s)

I will investigate it later. Setting the test as not required temporarily to bypass it.

xliuxu changed the title ~~[NOT FOR REVIEW]Tests WireGuard on ipv6 and ipv6 dual-stack clusters~~ [NOT FOR REVIEW]Test WireGuard on ipv6 and ipv6 dual-stack clusters Aug 30, 2021

xliuxu force-pushed the xliuxu_test_ci branch from 4746189 to 60fd190 Compare August 30, 2021 11:18

xliuxu force-pushed the xliuxu_test_ci branch from 60fd190 to 02ee291 Compare August 30, 2021 11:31

xliuxu force-pushed the xliuxu_test_ci branch from 02ee291 to b94fd52 Compare August 30, 2021 13:00

xliuxu force-pushed the xliuxu_test_ci branch 3 times, most recently from 199cf99 to b435f9d Compare August 31, 2021 02:41

xliuxu changed the title ~~[NOT FOR REVIEW]Test WireGuard on ipv6 and ipv6 dual-stack clusters~~ [CI]Generate ssh-config for all Nodes Aug 31, 2021

xliuxu requested a review from lzhecheng August 31, 2021 07:00

xliuxu force-pushed the xliuxu_test_ci branch from b435f9d to 502d741 Compare August 31, 2021 13:02

xliuxu force-pushed the xliuxu_test_ci branch from 502d741 to cbd258e Compare September 1, 2021 09:55

lzhecheng reviewed Sep 2, 2021

View reviewed changes

ci/jenkins/test.sh Show resolved Hide resolved

lzhecheng requested review from antoninbas and tnqn September 2, 2021 03:17

lzhecheng mentioned this pull request Sep 2, 2021

Fix agent nil panic in pure IPv6 cluster #2655

Merged

Generate ssh-config for all Nodes

ed03eaa

Make sure we can check kernel modules on all Nodes in the cluster. This is a prerequisite for WireGuard e2e tests. Fixes: antrea-io#2661 Signed-off-by: Xu Liu <[email protected]>

xliuxu force-pushed the xliuxu_test_ci branch from cbd258e to ed03eaa Compare September 2, 2021 14:05

tnqn approved these changes Sep 2, 2021

View reviewed changes

tnqn merged commit ff1bf06 into antrea-io:main Sep 2, 2021

tnqn mentioned this pull request Sep 2, 2021

Automated cherry pick of #2675: Generate ssh-config for all Nodes #2710

Merged

xliuxu deleted the xliuxu_test_ci branch September 3, 2021 03:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI]Generate ssh-config for all Nodes #2675

[CI]Generate ssh-config for all Nodes #2675

xliuxu commented Aug 30, 2021 •

edited

Loading

xliuxu commented Aug 30, 2021

codecov-commenter commented Aug 30, 2021 •

edited

Loading

xliuxu commented Aug 30, 2021

xliuxu commented Aug 30, 2021

xliuxu commented Aug 30, 2021

xliuxu commented Aug 30, 2021

xliuxu commented Aug 30, 2021

xliuxu commented Aug 31, 2021

lzhecheng commented Aug 31, 2021

xliuxu commented Aug 31, 2021

xliuxu commented Sep 1, 2021

lzhecheng commented Sep 1, 2021

xliuxu commented Sep 1, 2021

xliuxu commented Sep 1, 2021

xliuxu commented Sep 1, 2021

lzhecheng commented Sep 2, 2021

lzhecheng commented Sep 2, 2021

xliuxu commented Sep 2, 2021

tnqn left a comment

tnqn commented Sep 2, 2021

tnqn commented Sep 2, 2021

[CI]Generate ssh-config for all Nodes #2675

[CI]Generate ssh-config for all Nodes #2675

Conversation

xliuxu commented Aug 30, 2021 • edited Loading

xliuxu commented Aug 30, 2021

codecov-commenter commented Aug 30, 2021 • edited Loading

Codecov Report

xliuxu commented Aug 30, 2021

xliuxu commented Aug 30, 2021

xliuxu commented Aug 30, 2021

xliuxu commented Aug 30, 2021

xliuxu commented Aug 30, 2021

xliuxu commented Aug 31, 2021

lzhecheng commented Aug 31, 2021

xliuxu commented Aug 31, 2021

xliuxu commented Sep 1, 2021

lzhecheng commented Sep 1, 2021

xliuxu commented Sep 1, 2021

xliuxu commented Sep 1, 2021

xliuxu commented Sep 1, 2021

lzhecheng commented Sep 2, 2021

lzhecheng commented Sep 2, 2021

xliuxu commented Sep 2, 2021

tnqn left a comment

Choose a reason for hiding this comment

tnqn commented Sep 2, 2021

tnqn commented Sep 2, 2021

xliuxu commented Aug 30, 2021 •

edited

Loading

codecov-commenter commented Aug 30, 2021 •

edited

Loading