Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #2670: Fix init node transport interface bug (#2670) #2677

Conversation

antoninbas
Copy link
Contributor

Cherry pick of #2670 on release-1.3.

#2670: Fix init node transport interface bug (#2670)

For details on the cherry pick process, see the cherry pick requests page.

1.Fix adding node routes crash bug, which caused by uninitialized DualStackIPs
param.

2.Fix ipv4 address and ipv6 address confused bug and return the first ipv4 and
ipv6 ips for transport interface.

Signed-off-by: Wu zhengdong <[email protected]>
@antoninbas antoninbas added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Aug 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2021

Codecov Report

Merging #2677 (fd486fb) into release-1.3 (55ec2ad) will decrease coverage by 1.27%.
The diff coverage is 25.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.3    #2677      +/-   ##
===============================================
- Coverage        60.75%   59.48%   -1.28%     
===============================================
  Files              285      285              
  Lines            23003    23004       +1     
===============================================
- Hits             13976    13684     -292     
- Misses            7535     7865     +330     
+ Partials          1492     1455      -37     
Flag Coverage Δ
kind-e2e-tests 46.69% <25.00%> (-1.77%) ⬇️
unit-tests 41.09% <25.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/util/net.go 35.82% <0.00%> (-0.55%) ⬇️
...gent/controller/noderoute/node_route_controller.go 56.46% <100.00%> (+1.12%) ⬆️
...g/agent/apiserver/handlers/featuregates/handler.go 0.00% <0.00%> (-82.36%) ⬇️
...kg/apiserver/registry/system/supportbundle/rest.go 19.54% <0.00%> (-55.18%) ⬇️
pkg/support/dump_others.go 0.00% <0.00%> (-51.73%) ⬇️
...ver/registry/controlplane/nodestatssummary/rest.go 50.00% <0.00%> (-50.00%) ⬇️
pkg/support/dump.go 8.13% <0.00%> (-49.60%) ⬇️
...g/agent/apiserver/handlers/addressgroup/handler.go 0.00% <0.00%> (-40.00%) ⬇️
...agent/apiserver/handlers/appliedtogroup/handler.go 0.00% <0.00%> (-40.00%) ⬇️
pkg/apiserver/handlers/loglevel/handler.go 0.00% <0.00%> (-38.47%) ⬇️
... and 21 more

Copy link
Contributor

@lzhecheng lzhecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor Author

/skip-all

@antoninbas antoninbas merged commit 93d2d64 into antrea-io:release-1.3 Aug 31, 2021
@antoninbas antoninbas deleted the automated-cherry-pick-of-#2670-upstream-release-1.3 branch August 31, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants