Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for AntreaProxy to be ready before accessing Service #2858

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Sep 29, 2021

Otherwise components that rely on Service availability (e.g. agent
APIServer) would fail to initialize and crash the whole process.

Signed-off-by: Quan Tian [email protected]

Fixes #2857

Otherwise components that rely on Service availability (e.g. agent
APIServer) would fail to initialize and crash the whole process.

Signed-off-by: Quan Tian <[email protected]>
@tnqn tnqn added area/proxy Issues or PRs related to proxy functions in Antrea review-manager-test labels Sep 29, 2021
@tnqn
Copy link
Member Author

tnqn commented Sep 29, 2021

/test-all

@tnqn tnqn requested a review from lzhecheng September 29, 2021 16:16
Copy link
Contributor

@lzhecheng lzhecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@codecov-commenter
Copy link

Codecov Report

Merging #2858 (50d82a4) into main (3600834) will decrease coverage by 20.52%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2858       +/-   ##
===========================================
- Coverage   61.42%   40.90%   -20.53%     
===========================================
  Files         284      158      -126     
  Lines       23469    19544     -3925     
===========================================
- Hits        14417     7994     -6423     
- Misses       7501    10803     +3302     
+ Partials     1551      747      -804     
Flag Coverage Δ
kind-e2e-tests ?
unit-tests 40.90% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/proxy/proxier.go 42.23% <50.00%> (-17.97%) ⬇️
pkg/ovs/openflow/default.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/util/runtime/runtime.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/agent/cniserver/pod_configuration_linux.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/ovs/openflow/logs.go 9.52% <0.00%> (-90.48%) ⬇️
pkg/apis/controlplane/register.go 0.00% <0.00%> (-90.00%) ⬇️
pkg/agent/nodeportlocal/k8s/annotations.go 0.00% <0.00%> (-83.88%) ⬇️
pkg/agent/agent_linux.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/agent/client.go 0.00% <0.00%> (-77.42%) ⬇️
pkg/ovs/ovsconfig/ovs_client_linux.go 0.00% <0.00%> (-76.93%) ⬇️
... and 233 more

@tnqn
Copy link
Member Author

tnqn commented Sep 29, 2021

/test-e2e

@tnqn tnqn merged commit 3a86d2a into antrea-io:main Sep 30, 2021
@tnqn tnqn deleted the synchronize-antreaproxy branch September 30, 2021 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/proxy Issues or PRs related to proxy functions in Antrea review-manager-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error when creating agent API server may happen when proxyAll is enabled and kube-proxy is not deployed
4 participants