Added windows task delay up to 30s to improve job resiliency #2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peri Thompson <[email protected]>
|
/skip-all |
Codecov Report
@@ Coverage Diff @@
## main #2864 +/- ##
===========================================
- Coverage 61.54% 40.89% -20.66%
===========================================
Files 284 158 -126
Lines 23493 19562 -3931
===========================================
- Hits 14458 7999 -6459
- Misses 7481 10805 +3324
+ Partials 1554 758 -796
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lzhecheng
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
LGTM
It seems 30s is a common practice for New-JobTrigger:
https://serverfault.com/questions/820682/powershell-scheduled-job-not-running-at-startup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a randomdelay flag to the windows scheduled job to allow the task to run slightly after startup. Running directly At Startup can include a failure to initialise, where this delay allows a slight leeway to run a little after.
Fixes: #2826
Signed-off-by: Peri Thompson [email protected]