Add label value regexp pattern verification in CRD labelSelector matchExpressions #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2887 +/- ##
==========================================
+ Coverage 60.30% 60.42% +0.12%
==========================================
Files 283 283
Lines 23504 23644 +140
==========================================
+ Hits 14173 14287 +114
- Misses 7797 7817 +20
- Partials 1534 1540 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Wenqi Qiu <[email protected]>
tnqn
reviewed
Oct 19, 2021
| @@ -172,6 +172,7 @@ spec: | |||
| values: | |||
| items: | |||
| type: string | |||
| pattern: "^(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?$" | |||
There was a problem hiding this comment.
This applies to other CRDs that have "matchExpressions", could you address all of them in this PR?
There was a problem hiding this comment.
Sure, good idea. Done.
I think this PR title should be updated to Add label values regexp pattern verification in CRD labelSelector matchExpressions?
Signed-off-by: Wenqi Qiu <[email protected]>
wenqiq
changed the title
|
/test-e2e |
|
/test-conformance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve ExternalIPPool nodeSelector fields CRD schema verification
Fixes: #2573
Signed-off-by: Wenqi Qiu [email protected]