Ignore Services of type ExternalName in NodePortLocal Controller #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
added
the
area/proxy/nodeportlocal
Codecov Report
@@ Coverage Diff @@
## main #3114 +/- ##
==========================================
- Coverage 59.81% 51.39% -8.43%
==========================================
Files 331 303 -28
Lines 28437 36350 +7913
==========================================
+ Hits 17010 18681 +1671
- Misses 9549 15881 +6332
+ Partials 1878 1788 -90
Flags with carried forward coverage won't be shown. Click here to find out more.
|
monotosh-avi
previously approved these changes
Dec 13, 2021
For ExternalName Services, the selector is meaningless and should be ignored. Before this patch, the NPL Controller would treat these Services in the same way as ClusterIP / LoadBalancer Services. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
force-pushed
the
ignore-ExternalName-Services-in-NPL-controller
branch
from
895d4cf
to
de2186c
Compare
|
/test-all |
|
/test-e2e |
antoninbas
changed the title
jianjuns
approved these changes
Jan 31, 2022
antoninbas
added
the
action/release-note
|
Not backporting this unless there is a request to do so, as it is a very minor fix |
yanjunz97
pushed a commit
to yanjunz97/antrea
that referenced
this pull request
Feb 14, 2022
…rea-io#3114) For ExternalName Services, the selector is meaningless and should be ignored. Before this patch, the NPL Controller would treat these Services in the same way as ClusterIP / LoadBalancer Services. Signed-off-by: Antonin Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ExternalName Services, the selector is meaningless and should be
ignored. Before this patch, the NPL Controller would treat these
Services in the same way as ClusterIP / LoadBalancer Services.
Signed-off-by: Antonin Bas [email protected]