-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix markdownlint verification MD050/strong-style #3283
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdownlint-cli 0.31.0 adds MD050/strong-style which requires consistent emphasis/strong style. Signed-off-by: Quan Tian <[email protected]>
/skip-all |
antoninbas
approved these changes
Feb 8, 2022
I don't remember how we install markdownlint, but that may need to be cherry-picked to release branches to avoid CI issues? We may want to pin the markdownlint version as well to avoid such issues in the future? |
tnqn
added a commit
to tnqn/antrea
that referenced
this pull request
Feb 9, 2022
To avoid issues such as antrea-io#3283, pin markdownlint version. markdownlint version should be upgraded manually when necessary. Signed-off-by: Quan Tian <[email protected]>
This was referenced Feb 9, 2022
tnqn
added a commit
to tnqn/antrea
that referenced
this pull request
Feb 9, 2022
To avoid issues such as antrea-io#3283, pin markdownlint version. markdownlint version should be upgraded manually when necessary. Signed-off-by: Quan Tian <[email protected]>
tnqn
added a commit
to tnqn/antrea
that referenced
this pull request
Feb 9, 2022
To avoid issues such as antrea-io#3283, pin markdownlint version. markdownlint version should be upgraded manually when necessary. Signed-off-by: Quan Tian <[email protected]>
tnqn
added a commit
to tnqn/antrea
that referenced
this pull request
Feb 9, 2022
To avoid issues such as antrea-io#3283, pin markdownlint version. markdownlint version should be upgraded manually when necessary. Signed-off-by: Quan Tian <[email protected]>
tnqn
added a commit
to tnqn/antrea
that referenced
this pull request
Feb 9, 2022
To avoid issues such as antrea-io#3283, pin markdownlint version. markdownlint version should be upgraded manually when necessary. Signed-off-by: Quan Tian <[email protected]>
@antoninbas makes sense, created PRs to pin the version and cherry-picked them. |
antoninbas
pushed a commit
that referenced
this pull request
Feb 9, 2022
To avoid issues such as #3283, pin markdownlint version. markdownlint version should be upgraded manually when necessary. Signed-off-by: Quan Tian <[email protected]>
tnqn
added a commit
that referenced
this pull request
Feb 10, 2022
…trong-style (#3290) * Fix markdownlint verification MD050/strong-style markdownlint-cli 0.31.0 adds MD050/strong-style which requires consistent emphasis/strong style. Signed-off-by: Quan Tian <[email protected]> * Pin markdownlint version for consistent verification result To avoid issues such as #3283, pin markdownlint version. markdownlint version should be upgraded manually when necessary. Signed-off-by: Quan Tian <[email protected]>
tnqn
added a commit
that referenced
this pull request
Feb 10, 2022
…trong-style (#3291) * Fix markdownlint verification MD050/strong-style markdownlint-cli 0.31.0 adds MD050/strong-style which requires consistent emphasis/strong style. Signed-off-by: Quan Tian <[email protected]> * Pin markdownlint version for consistent verification result To avoid issues such as #3283, pin markdownlint version. markdownlint version should be upgraded manually when necessary. Signed-off-by: Quan Tian <[email protected]>
tnqn
added a commit
that referenced
this pull request
Feb 10, 2022
…trong-style (#3292) * Fix markdownlint verification MD050/strong-style markdownlint-cli 0.31.0 adds MD050/strong-style which requires consistent emphasis/strong style. Signed-off-by: Quan Tian <[email protected]> * Pin markdownlint version for consistent verification result To avoid issues such as #3283, pin markdownlint version. markdownlint version should be upgraded manually when necessary. Signed-off-by: Quan Tian <[email protected]>
tnqn
added a commit
that referenced
this pull request
Feb 10, 2022
…trong-style (#3293) * Fix markdownlint verification MD050/strong-style markdownlint-cli 0.31.0 adds MD050/strong-style which requires consistent emphasis/strong style. Signed-off-by: Quan Tian <[email protected]> * Pin markdownlint version for consistent verification result To avoid issues such as #3283, pin markdownlint version. markdownlint version should be upgraded manually when necessary. Signed-off-by: Quan Tian <[email protected]>
yanjunz97
pushed a commit
to yanjunz97/antrea
that referenced
this pull request
Feb 14, 2022
markdownlint-cli 0.31.0 adds MD050/strong-style which requires consistent emphasis/strong style. Signed-off-by: Quan Tian <[email protected]>
yanjunz97
pushed a commit
to yanjunz97/antrea
that referenced
this pull request
Feb 14, 2022
…o#3289) To avoid issues such as antrea-io#3283, pin markdownlint version. markdownlint version should be upgraded manually when necessary. Signed-off-by: Quan Tian <[email protected]>
bangqipropel
pushed a commit
to bangqipropel/antrea
that referenced
this pull request
Mar 2, 2022
markdownlint-cli 0.31.0 adds MD050/strong-style which requires consistent emphasis/strong style. Signed-off-by: Quan Tian <[email protected]>
bangqipropel
pushed a commit
to bangqipropel/antrea
that referenced
this pull request
Mar 2, 2022
…o#3289) To avoid issues such as antrea-io#3283, pin markdownlint version. markdownlint version should be upgraded manually when necessary. Signed-off-by: Quan Tian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
markdownlint-cli 0.31.0 adds MD050/strong-style which requires
consistent emphasis/strong style.
Signed-off-by: Quan Tian [email protected]