Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdownlint verification MD050/strong-style #3283

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Feb 8, 2022

markdownlint-cli 0.31.0 adds MD050/strong-style which requires
consistent emphasis/strong style.

Signed-off-by: Quan Tian [email protected]

markdownlint-cli 0.31.0 adds MD050/strong-style which requires
consistent emphasis/strong style.

Signed-off-by: Quan Tian <[email protected]>
@tnqn tnqn requested a review from antoninbas February 8, 2022 16:05
@tnqn
Copy link
Member Author

tnqn commented Feb 8, 2022

/skip-all

@antoninbas antoninbas merged commit e2fcfa8 into antrea-io:main Feb 8, 2022
@antoninbas
Copy link
Contributor

I don't remember how we install markdownlint, but that may need to be cherry-picked to release branches to avoid CI issues? We may want to pin the markdownlint version as well to avoid such issues in the future?

@tnqn tnqn deleted the fix-doc branch February 9, 2022 03:06
tnqn added a commit to tnqn/antrea that referenced this pull request Feb 9, 2022
To avoid issues such as antrea-io#3283, pin markdownlint version.

markdownlint version should be upgraded manually when necessary.

Signed-off-by: Quan Tian <[email protected]>
tnqn added a commit to tnqn/antrea that referenced this pull request Feb 9, 2022
To avoid issues such as antrea-io#3283, pin markdownlint version.

markdownlint version should be upgraded manually when necessary.

Signed-off-by: Quan Tian <[email protected]>
tnqn added a commit to tnqn/antrea that referenced this pull request Feb 9, 2022
To avoid issues such as antrea-io#3283, pin markdownlint version.

markdownlint version should be upgraded manually when necessary.

Signed-off-by: Quan Tian <[email protected]>
tnqn added a commit to tnqn/antrea that referenced this pull request Feb 9, 2022
To avoid issues such as antrea-io#3283, pin markdownlint version.

markdownlint version should be upgraded manually when necessary.

Signed-off-by: Quan Tian <[email protected]>
tnqn added a commit to tnqn/antrea that referenced this pull request Feb 9, 2022
To avoid issues such as antrea-io#3283, pin markdownlint version.

markdownlint version should be upgraded manually when necessary.

Signed-off-by: Quan Tian <[email protected]>
@tnqn
Copy link
Member Author

tnqn commented Feb 9, 2022

@antoninbas makes sense, created PRs to pin the version and cherry-picked them.

antoninbas pushed a commit that referenced this pull request Feb 9, 2022
To avoid issues such as #3283, pin markdownlint version.

markdownlint version should be upgraded manually when necessary.

Signed-off-by: Quan Tian <[email protected]>
tnqn added a commit that referenced this pull request Feb 10, 2022
…trong-style (#3290)

* Fix markdownlint verification MD050/strong-style

markdownlint-cli 0.31.0 adds MD050/strong-style which requires
consistent emphasis/strong style.

Signed-off-by: Quan Tian <[email protected]>

* Pin markdownlint version for consistent verification result

To avoid issues such as #3283, pin markdownlint version.

markdownlint version should be upgraded manually when necessary.

Signed-off-by: Quan Tian <[email protected]>
tnqn added a commit that referenced this pull request Feb 10, 2022
…trong-style (#3291)

* Fix markdownlint verification MD050/strong-style

markdownlint-cli 0.31.0 adds MD050/strong-style which requires
consistent emphasis/strong style.

Signed-off-by: Quan Tian <[email protected]>

* Pin markdownlint version for consistent verification result

To avoid issues such as #3283, pin markdownlint version.

markdownlint version should be upgraded manually when necessary.

Signed-off-by: Quan Tian <[email protected]>
tnqn added a commit that referenced this pull request Feb 10, 2022
…trong-style (#3292)

* Fix markdownlint verification MD050/strong-style

markdownlint-cli 0.31.0 adds MD050/strong-style which requires
consistent emphasis/strong style.

Signed-off-by: Quan Tian <[email protected]>

* Pin markdownlint version for consistent verification result

To avoid issues such as #3283, pin markdownlint version.

markdownlint version should be upgraded manually when necessary.

Signed-off-by: Quan Tian <[email protected]>
tnqn added a commit that referenced this pull request Feb 10, 2022
…trong-style (#3293)

* Fix markdownlint verification MD050/strong-style

markdownlint-cli 0.31.0 adds MD050/strong-style which requires
consistent emphasis/strong style.

Signed-off-by: Quan Tian <[email protected]>

* Pin markdownlint version for consistent verification result

To avoid issues such as #3283, pin markdownlint version.

markdownlint version should be upgraded manually when necessary.

Signed-off-by: Quan Tian <[email protected]>
yanjunz97 pushed a commit to yanjunz97/antrea that referenced this pull request Feb 14, 2022
markdownlint-cli 0.31.0 adds MD050/strong-style which requires
consistent emphasis/strong style.

Signed-off-by: Quan Tian <[email protected]>
yanjunz97 pushed a commit to yanjunz97/antrea that referenced this pull request Feb 14, 2022
…o#3289)

To avoid issues such as antrea-io#3283, pin markdownlint version.

markdownlint version should be upgraded manually when necessary.

Signed-off-by: Quan Tian <[email protected]>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this pull request Mar 2, 2022
markdownlint-cli 0.31.0 adds MD050/strong-style which requires
consistent emphasis/strong style.

Signed-off-by: Quan Tian <[email protected]>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this pull request Mar 2, 2022
…o#3289)

To avoid issues such as antrea-io#3283, pin markdownlint version.

markdownlint version should be upgraded manually when necessary.

Signed-off-by: Quan Tian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants