-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Enable EndpointSlices support on Antrea windows #3321
Conversation
/test-windows-all |
Codecov Report
@@ Coverage Diff @@
## main #3321 +/- ##
==========================================
+ Coverage 60.95% 61.05% +0.09%
==========================================
Files 266 266
Lines 26508 26520 +12
==========================================
+ Hits 16159 16191 +32
+ Misses 8597 8542 -55
- Partials 1752 1787 +35
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test-windows-networkpolicy |
2b349ef
to
147b747
Compare
/test-windows-proxyall-e2e |
/test-windows-proxyall-e2e |
third_party/proxy/config/config.go
Outdated
@@ -347,7 +347,8 @@ func (c *EndpointSliceConfig) handleUpdateEndpointSlice(oldObj, newObj interface | |||
return | |||
} | |||
for _, h := range c.eventHandlers { | |||
klog.V(4).Infof("Calling handler.OnEndpointSliceUpdate") | |||
klog.V(4).Infof("Calling handler.OnEndpointSliceUpdate from %+v", oldEndpointSlice) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use klog.V(4).InfoS()?
One log including both old and new Endpointslice is enought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
third_party/proxy/config/config.go
Outdated
@@ -366,7 +367,7 @@ func (c *EndpointSliceConfig) handleDeleteEndpointSlice(obj interface{}) { | |||
} | |||
} | |||
for _, h := range c.eventHandlers { | |||
klog.V(4).Infof("Calling handler.OnEndpointsDelete") | |||
klog.V(4).Infof("Calling handler.OnEndpointsDelete %+v", endpointSlice) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, thanks!
/test-windows-all |
@wenyingd Hi Wenying,do you have more comments on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
third_party/proxy/config/config.go
Outdated
@@ -330,7 +330,7 @@ func (c *EndpointSliceConfig) handleAddEndpointSlice(obj interface{}) { | |||
return | |||
} | |||
for _, h := range c.eventHandlers { | |||
klog.V(4).Infof("Calling handler.OnEndpointSliceAdd %+v", endpointSlice) | |||
klog.V(4).InfoS("Calling handler.OnEndpointSliceAdd", endpointSlice) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
structured logging must have pairs of key and value, otherwise the log wouldn't be formated properly.
InfoS("log body", "key1", value1, "key2", values)
It should be klog.V(4).InfoS("Calling handler.OnEndpointSliceAdd", "endpointSlice", endpointSlice)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, thanks @tnqn.
* Enable endpointslices feature in antrea-windows.yml * Make some endpointslices logs more accurate Signed-off-by: Shuyang Xin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-windows-all |
…3321) * Enable endpointslices feature in antrea-windows.yml * Make some endpointslices logs more accurate Signed-off-by: Shuyang Xin <[email protected]>
Signed-off-by: Shuyang Xin [email protected]