Automated cherry pick of #3295: Fix NodePort/LoadBalancer issue when proxyAll is enabled #3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When proxyAll is enabled, create a NodePort/LoadBalancer Service whose externalTrafficPolicy is Cluster, then only an OVS group with all Endpoints will be installed. If change externalTrafficPolicy of the Service from Cluster to Local, an OVS group with only local Endpoints should be also installed since externalTrafficPolicy is Local, but it is not. This patch fixes the issue that OVS group with only local Endpoints is not installed when externalTrafficPolicy of Service is changed from Cluster to Local. Signed-off-by: Hongliang Liu <[email protected]>
hongliangl
added
the
kind/cherry-pick
|
/test-all-features-conformance |
tnqn
approved these changes
Feb 17, 2022
Codecov Report
@@ Coverage Diff @@
## release-1.4 #3329 +/- ##
===============================================
+ Coverage 59.80% 60.91% +1.11%
===============================================
Files 290 290
Lines 24543 24550 +7
===============================================
+ Hits 14677 14955 +278
+ Misses 8260 7971 -289
- Partials 1606 1624 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test-all |
2 similar comments
|
/test-all |
|
/test-all |
|
/test-e2e |
|
/skip-e2e which failed on unrelated test: TestFlowAggregator |
hongliangl
deleted the
automated-cherry-pick-of-#3295-upstream-release-1.4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #3295 on release-1.4.
#3295: Fix NodePort/LoadBalancer issue when proxyAll is enabled
For details on the cherry pick process, see the cherry pick requests page.