Validate labels in ANP/ACNP/CG #3331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GraysonWu
force-pushed
the
validate-label
branch
2 times, most recently
from
989f958
to
9d65f45
Compare
|
LGTM, but do you think we should do the same for labelSelectors in ClusterGroups as well? |
GraysonWu
force-pushed
the
validate-label
branch
2 times, most recently
from
bf0d5c7
to
cc03d67
Compare
Good catch. Added. |
Codecov Report
@@ Coverage Diff @@
## main #3331 +/- ##
==========================================
+ Coverage 60.85% 62.02% +1.16%
==========================================
Files 266 269 +3
Lines 26520 26733 +213
==========================================
+ Hits 16139 16581 +442
+ Misses 8591 8340 -251
- Partials 1790 1812 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Fixes antrea-io#3285. This PR added some additional validations to ANP, ACNP and CG in validating webhook. Antrea will validate labels used in ANP, ACNP and CG under PodSelector, NamespaceSelector and ExternalEntitySelector. Signed-off-by: wgrayson <[email protected]>
GraysonWu
force-pushed
the
validate-label
branch
from
cc03d67
to
81e4ad5
Compare
|
/test-all |
|
/test-integration |
tnqn
added
the
action/release-note
bangqipropel
pushed a commit
to bangqipropel/antrea
that referenced
this pull request
Mar 2, 2022
Fixes antrea-io#3285. This PR added some additional validations to ANP, ACNP and CG in validating webhook. Antrea will validate labels used in ANP, ACNP and CG under PodSelector, NamespaceSelector and ExternalEntitySelector. Signed-off-by: wgrayson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3285.
This PR added some additional validations to ANP, ACNP and CG in
validating webhook. Antrea will validate labels used in ANP, ACNP and
CG under PodSelector, NamespaceSelector and ExternalEntitySelector.
Signed-off-by: wgrayson [email protected]