Don't delete the routes which are added for the peer IPv6 gateways #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jexf
force-pushed
the
fix-ipv6-gateway
branch
from
b727933
to
c9933e9
Compare
Codecov Report
@@ Coverage Diff @@
## main #3336 +/- ##
==========================================
- Coverage 62.00% 54.34% -7.67%
==========================================
Files 266 373 +107
Lines 26546 51052 +24506
==========================================
+ Hits 16460 27742 +11282
- Misses 8281 20890 +12609
- Partials 1805 2420 +615
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test-all |
|
/test-ipv6-all |
Jexf
force-pushed
the
fix-ipv6-gateway
branch
from
c9933e9
to
979ae97
Compare
|
/test-all |
IPv6 doesn't support "on-link" route, routes to the peer IPv6 gateways need to be added separately. So don't delete such routes. Signed-off-by: Wu zhengdong <[email protected]>
|
/test-all |
|
/test-integration |
tnqn
added
the
action/release-note
|
/test-integration |
|
test-integration failure has been fixed in main branch but this commit doesn't rebase on it. Unfortunately the job tests HEAD commit instead of merge commit, so no point to keep retrying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPv6 doesn't support "on-link" route, routes to the peer IPv6 gateways need to be added separately. So don't delete such routes.
Fixes: #3369
Signed-off-by: Wu zhengdong [email protected]