-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate the protocol in the crd schema #3342
Conversation
Signed-off-by: KMAnju-2021 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3342 +/- ##
==========================================
- Coverage 60.85% 58.54% -2.32%
==========================================
Files 266 266
Lines 26520 26520
==========================================
- Hits 16139 15525 -614
- Misses 8591 9280 +689
+ Partials 1790 1715 -75
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KMAnju-2021 thanks for the fix. Please link the issue to this PR by adding a line "Fixes #<ISSUE ID>"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
/skip-all |
Signed-off-by: KMAnju-2021 <[email protected]>
Fixes #3262
This commit fixed the issue of Network Policy does not validate protocol and accept wrong configuration.
Signed-off-by: KMAnju-2021 [email protected]