-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add upgrade guide for Multi-cluster #3374
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3374 +/- ##
===========================================
- Coverage 65.57% 48.28% -17.30%
===========================================
Files 278 459 +181
Lines 27770 45642 +17872
===========================================
+ Hits 18210 22037 +3827
- Misses 7642 21342 +13700
- Partials 1918 2263 +345
Flags with carried forward coverage won't be shown. Click here to find out more.
|
97aab41
to
9a330ff
Compare
Hi @jianjuns @Dyanngg @aravindakidambi Could you help to review this PR? thanks! |
a2511e3
to
98439c5
Compare
98439c5
to
8a17dac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nit.
8a17dac
to
fe5a594
Compare
fe5a594
to
f71ff02
Compare
@jianjuns do you have any new comments for this PR? thanks. |
f71ff02
to
488a08e
Compare
Signed-off-by: Lan Luo <[email protected]>
488a08e
to
2dd9cfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/skip-all |
/skip-all |
DCO check is missing somehow, ignore it as the PR is signed appropriately apparently |
Signed-off-by: Lan Luo [email protected]