Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade guide for Multi-cluster #3374

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Conversation

luolanzone
Copy link
Contributor

Signed-off-by: Lan Luo [email protected]

@luolanzone luolanzone added the area/multi-cluster Issues or PRs related to multi cluster. label Mar 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2022

Codecov Report

Merging #3374 (2dd9cfb) into main (f0c3cbe) will decrease coverage by 17.29%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3374       +/-   ##
===========================================
- Coverage   65.57%   48.28%   -17.30%     
===========================================
  Files         278      459      +181     
  Lines       27770    45642    +17872     
===========================================
+ Hits        18210    22037     +3827     
- Misses       7642    21342    +13700     
- Partials     1918     2263      +345     
Flag Coverage Δ
integration-tests 32.93% <ø> (?)
kind-e2e-tests 39.68% <ø> (-15.54%) ⬇️
unit-tests 43.30% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apis/controlplane/types.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/agent/controller/networkpolicy/reject.go 0.00% <0.00%> (-87.91%) ⬇️
...g/agent/apiserver/handlers/featuregates/handler.go 0.00% <0.00%> (-82.36%) ⬇️
pkg/controller/networkpolicy/mutate.go 0.00% <0.00%> (-73.57%) ⬇️
pkg/agent/flowexporter/utils.go 0.00% <0.00%> (-71.43%) ⬇️
pkg/controller/networkpolicy/store/group.go 5.00% <0.00%> (-70.00%) ⬇️
pkg/agent/controller/networkpolicy/packetin.go 0.00% <0.00%> (-68.37%) ⬇️
pkg/apis/controlplane/helper.go 33.33% <0.00%> (-66.67%) ⬇️
pkg/apis/controlplane/v1beta2/helper.go 33.33% <0.00%> (-66.67%) ⬇️
pkg/controller/networkpolicy/convert.go 0.00% <0.00%> (-64.52%) ⬇️
... and 263 more

@luolanzone
Copy link
Contributor Author

Hi @jianjuns @Dyanngg @aravindakidambi Could you help to review this PR? thanks!

docs/multicluster/upgrade.md Outdated Show resolved Hide resolved
docs/multicluster/upgrade.md Outdated Show resolved Hide resolved
docs/multicluster/upgrade.md Outdated Show resolved Hide resolved
docs/multicluster/upgrade.md Outdated Show resolved Hide resolved
docs/multicluster/upgrade.md Outdated Show resolved Hide resolved
docs/multicluster/upgrade.md Outdated Show resolved Hide resolved
docs/multicluster/upgrade.md Outdated Show resolved Hide resolved
docs/multicluster/upgrade.md Show resolved Hide resolved
@luolanzone luolanzone force-pushed the mc-upgrade-doc branch 2 times, most recently from a2511e3 to 98439c5 Compare March 10, 2022 07:11
docs/multicluster/api.md Outdated Show resolved Hide resolved
docs/multicluster/api.md Outdated Show resolved Hide resolved
docs/multicluster/upgrade.md Outdated Show resolved Hide resolved
docs/multicluster/upgrade.md Outdated Show resolved Hide resolved
docs/multicluster/upgrade.md Outdated Show resolved Hide resolved
jianjuns
jianjuns previously approved these changes Mar 11, 2022
Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit.

docs/multicluster/api.md Outdated Show resolved Hide resolved
@luolanzone
Copy link
Contributor Author

@jianjuns do you have any new comments for this PR? thanks.

jianjuns
jianjuns previously approved these changes Mar 17, 2022
docs/multicluster/upgrade.md Outdated Show resolved Hide resolved
docs/multicluster/upgrade.md Outdated Show resolved Hide resolved
docs/multicluster/upgrade.md Outdated Show resolved Hide resolved
docs/multicluster/upgrade.md Outdated Show resolved Hide resolved
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn tnqn closed this Mar 25, 2022
@tnqn tnqn reopened this Mar 25, 2022
@tnqn
Copy link
Member

tnqn commented Mar 25, 2022

/skip-all

@tnqn tnqn added the action/release-note Indicates a PR that should be included in release notes. label Mar 25, 2022
@tnqn
Copy link
Member

tnqn commented Mar 25, 2022

/skip-all

@tnqn
Copy link
Member

tnqn commented Mar 25, 2022

DCO check is missing somehow, ignore it as the PR is signed appropriately apparently

@tnqn tnqn merged commit a539b78 into antrea-io:main Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/release-note Indicates a PR that should be included in release notes. area/multi-cluster Issues or PRs related to multi cluster.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants