Unconditionally sync CA cert for Controller webhooks #3421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
added
kind/bug
Webhooks are used by other features besided AntreaPolicy. At the moment, if someone tries to disable AnteraPolicy and enable Egress for example, the webhooks would not be using the correct CA cert and the Egress API would not be usable. Given that we unconditionally create these webhooks in the Antrea deployment manifest, it makes sense to unconditionally sync the CA cert for them. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
force-pushed
the
unconditionally-sync-cacert-for-webhooks
branch
from
033458e
to
7a5e3fe
Compare
Codecov Report
@@ Coverage Diff @@
## main #3421 +/- ##
===========================================
+ Coverage 42.41% 53.67% +11.26%
===========================================
Files 200 239 +39
Lines 24296 34209 +9913
===========================================
+ Hits 10305 18362 +8057
- Misses 12929 14075 +1146
- Partials 1062 1772 +710
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test-e2e |
GraysonWu
pushed a commit
to GraysonWu/antrea
that referenced
this pull request
Mar 10, 2022
Webhooks are used by other features besided AntreaPolicy. At the moment, if someone tries to disable AnteraPolicy and enable Egress for example, the webhooks would not be using the correct CA cert and the Egress API would not be usable. Given that we unconditionally create these webhooks in the Antrea deployment manifest, it makes sense to unconditionally sync the CA cert for them. Signed-off-by: Antonin Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webhooks are used by other features besided AntreaPolicy. At the moment,
if someone tries to disable AnteraPolicy and enable Egress for example,
the webhooks would not be using the correct CA cert and the Egress API
would not be usable.
Given that we unconditionally create these webhooks in the Antrea
deployment manifest, it makes sense to unconditionally sync the CA cert
for them.
Signed-off-by: Antonin Bas [email protected]