Fix incorrect results by antctl get networkpolicy on Pods
#3499
Conversation
Dyanngg
added
kind/bug
Codecov Report
@@ Coverage Diff @@
## main #3499 +/- ##
==========================================
- Coverage 65.46% 63.37% -2.09%
==========================================
Files 278 278
Lines 27771 27774 +3
==========================================
- Hits 18179 17603 -576
- Misses 7666 8332 +666
+ Partials 1926 1839 -87
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tnqn
added
the
action/release-note
| return nil, fmt.Errorf("with a name, none of the other fields can be set") | ||
| return nil, "", fmt.Errorf("with a name, none of the other fields can be set") | ||
| } | ||
| // In case of getting policies applied to a specific Pod, the -n option is used to specify the |
There was a problem hiding this comment.
I feel it's confusing that "-n" stands for the namespace of the Pod in one case and stands for the namespace filter of networkpolicies in another case.
Could we ask for "-p ns/pod" for the former case to be clear?
There was a problem hiding this comment.
@GraysonWu and I thought about this when we discussed how to fix this issue. The problem by going with "-p ns/pod" is that it doesn't make much sense for -p and -n to be used in conjunction anymore. Do you think we should disable this usage?
There was a problem hiding this comment.
Changed to "-p ns/pod" in the latest commit
|
This PR came late for Antrea 1.6.0, we can set it as stretched goal. |
|
/test-all |
|
/test-integration |
|
/test-all |
Signed-off-by: Yang Ding <[email protected]>
Signed-off-by: Yang Ding <[email protected]>
Dyanngg
force-pushed
the
fix-antctl-get-policy
branch
from
d366f3c
to
e6a3079
Compare
|
Fixed lint issue /test-all /test-integration |
|
/test-integration |
When the
-p <PodName> -n <PodNamespace>options are used inantctl get networkpolicycommand, the-noption should only be used to identify the Pod being queried, but not filter any internal policies based on the Namespace. Otherwise, all ACNPs applied to the Pod will be filtered out.This PR also fixes an issue where duplicate policy names are displayed.
Signed-off-by: Yang Ding [email protected]