Export Service's name to support multi-ports #3561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-multicluster-e2e |
Codecov Report
@@ Coverage Diff @@
## main #3561 +/- ##
===========================================
+ Coverage 38.12% 64.16% +26.03%
===========================================
Files 114 278 +164
Lines 15271 27821 +12550
===========================================
+ Hits 5822 17850 +12028
+ Misses 8967 8061 -906
- Partials 482 1910 +1428
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/test-multicluster-e2e |
luolanzone
force-pushed
the
fix-multiports
branch
from
080a8c9
to
9c9e882
Compare
|
/test-multicluster-e2e |
luolanzone
force-pushed
the
fix-multiports
branch
from
9c9e882
to
fa65a13
Compare
|
/test-multicluster-e2e |
luolanzone
force-pushed
the
fix-multiports
branch
from
fa65a13
to
e1a93f8
Compare
|
/test-multicluster-e2e |
luolanzone
force-pushed
the
fix-multiports
branch
from
e1a93f8
to
72b8bc7
Compare
|
/test-multicluster-e2e |
2 similar comments
|
/test-multicluster-e2e |
|
/test-multicluster-e2e |
luolanzone
force-pushed
the
fix-multiports
branch
from
72b8bc7
to
82529b5
Compare
|
/test-multicluster-e2e |
1 similar comment
|
/test-multicluster-e2e |
jianjuns
reviewed
Apr 1, 2022
docs/multicluster/user-guide.md
Outdated
| @@ -412,8 +412,8 @@ converging the update until users correct it to match the Service definition in | |||
| ResourceImport. | |||
| 2. When a member cluster has already exported a Service, e.g.: `default/nginx` with TCP | |||
| Port `80`, then other member clusters can only export the same Service with the same Ports | |||
| definition. Otherwise, Antrea Multi-cluster Controller will skip converging the mismatched | |||
| ResourceExport into the corresponding ResourceImport until users correct it. | |||
| definition including port's name. Otherwise, Antrea Multi-cluster Controller will skip converging | |||
There was a problem hiding this comment.
port names or ports' names
converging -> converting?
Signed-off-by: Lan Luo <[email protected]>
luolanzone
force-pushed
the
fix-multiports
branch
from
82529b5
to
93ac6fb
Compare
jianjuns
approved these changes
Apr 6, 2022
tnqn
approved these changes
Apr 6, 2022
|
/skip-all |
|
/test-multicluster-e2e |
1 similar comment
|
/test-multicluster-e2e |
tnqn
added
action/backport
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v1.5, we removed original Service name during export/import, but the CNI will fail to realize the Service/Endpoint due to imported Endpoint still has original name, we export Service's name in this PR so we can fix this kind of issue and also support Service with multiple ports.
Fixes #3588
Signed-off-by: Lan Luo [email protected]