Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve flow visibility documentation #3667

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

antoninbas
Copy link
Contributor

@antoninbas antoninbas commented Apr 20, 2022

  • fix link to ClickHouse operator YAML manifest
  • add note about traffic which is excluded by default in Grafana
    dashboards

Signed-off-by: Antonin Bas [email protected]

@antoninbas antoninbas requested a review from heanlan April 20, 2022 00:17
@antoninbas antoninbas added kind/documentation Categorizes issue or PR as related to a documentation. area/flow-visibility Issues or PRs related to flow visibility support in Antrea labels Apr 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #3667 (eee4068) into main (a566009) will decrease coverage by 2.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3667      +/-   ##
==========================================
- Coverage   64.58%   62.27%   -2.31%     
==========================================
  Files         278      278              
  Lines       39363    39363              
==========================================
- Hits        25421    24515     -906     
- Misses      11963    12949     +986     
+ Partials     1979     1899      -80     
Flag Coverage Δ
kind-e2e-tests 48.84% <ø> (-3.45%) ⬇️
unit-tests 43.82% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/agent/apiserver/handlers/featuregates/handler.go 4.54% <0.00%> (-77.28%) ⬇️
pkg/controller/egress/store/egressgroup.go 1.72% <0.00%> (-54.32%) ⬇️
...kg/apiserver/registry/system/supportbundle/rest.go 22.17% <0.00%> (-50.44%) ⬇️
pkg/support/dump.go 7.90% <0.00%> (-49.16%) ⬇️
pkg/support/dump_others.go 0.00% <0.00%> (-44.74%) ⬇️
...gregator/apiserver/handlers/flowrecords/handler.go 1.44% <0.00%> (-37.69%) ⬇️
...egator/apiserver/handlers/recordmetrics/handler.go 4.00% <0.00%> (-36.00%) ⬇️
...g/agent/apiserver/handlers/addressgroup/handler.go 5.00% <0.00%> (-35.00%) ⬇️
...agent/apiserver/handlers/appliedtogroup/handler.go 5.00% <0.00%> (-35.00%) ⬇️
pkg/apiserver/handlers/loglevel/handler.go 6.25% <0.00%> (-31.25%) ⬇️
... and 37 more

heanlan
heanlan previously approved these changes Apr 20, 2022
Copy link
Contributor

@heanlan heanlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Antonin for the PR

@heanlan
Copy link
Contributor

heanlan commented Apr 20, 2022

There's a typo in the commit message. "tarffic"

* fix link to ClickHouse operator YAML manifest
* add note about traffic which is excluded by default in Grafana
  dashboards

Signed-off-by: Antonin Bas <[email protected]>
@antoninbas
Copy link
Contributor Author

/skip-all

@antoninbas antoninbas merged commit 5905e98 into antrea-io:main Apr 20, 2022
@antoninbas antoninbas deleted the improve-flow-visibility-doc branch April 20, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/flow-visibility Issues or PRs related to flow visibility support in Antrea kind/documentation Categorizes issue or PR as related to a documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants