Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #3510: Fix the issue of local probe bypassing flows on Windows #3715

Conversation

hongliangl
Copy link
Contributor

When proxyAll is enabled, kube-proxy can be replaced by AntreaProxy, then
Service traffic and non-Service traffic can be distinguished by ServiceCTMark
and NotServiceCTMark. Service traffic with ServiceCTMark should not bypass
Network Policies, and non-Service traffic generated by kubelet with
NotServiceCTMark should bypass Network Policies.

Signed-off-by: Hongliang Liu [email protected]

When proxyAll is enabled, kube-proxy can be replaced by AntreaProxy, then
Service traffic and non-Service traffic can be distinguished by ServiceCTMark
and NotServiceCTMark. Service traffic with ServiceCTMark should not bypass
Network Policies, and non-Service traffic generated by kubelet with
NotServiceCTMark should bypass Network Policies.

Signed-off-by: Hongliang Liu <[email protected]>
@hongliangl hongliangl added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Apr 29, 2022
@hongliangl hongliangl requested a review from Dyanngg April 29, 2022 05:37
@hongliangl
Copy link
Contributor Author

/test-all-features-conformance
/test-conformance
/test-e2e
/test-flexible-ipam-e2e
/test-ipv6-conformance
/test-ipv6-e2e
/test-ipv6-networkpolicy
/test-ipv6-only-conformance
/test-ipv6-only-e2e
/test-ipv6-only-networkpolicy
/test-multicluster-e2e
/test-networkpolicy
/test-windows-conformance
/test-windows-e2e
/test-windows-networkpolicy
/test-windows-proxyall-e2e
/test-integration

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2022

Codecov Report

Merging #3715 (e38ce74) into release-1.6 (f3208e7) will decrease coverage by 11.82%.
The diff coverage is 47.82%.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-1.6    #3715       +/-   ##
================================================
- Coverage        64.19%   52.36%   -11.83%     
================================================
  Files              278      392      +114     
  Lines            27837    53510    +25673     
================================================
+ Hits             17870    28022    +10152     
- Misses            8045    22983    +14938     
- Partials          1922     2505      +583     
Flag Coverage Δ
e2e-tests 40.61% <47.82%> (?)
integration-tests 38.19% <ø> (?)
kind-e2e-tests 51.21% <45.00%> (-0.07%) ⬇️
unit-tests 43.34% <20.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/openflow/pipeline.go 71.70% <33.33%> (-2.47%) ⬇️
pkg/agent/openflow/client.go 66.71% <100.00%> (-2.71%) ⬇️
pkg/agent/openflow/pod_connectivity.go 61.72% <100.00%> (-6.70%) ⬇️
pkg/controller/types/networkpolicy.go 50.00% <0.00%> (-50.00%) ⬇️
pkg/agent/cniserver/pod_configuration_linux.go 26.31% <0.00%> (-40.36%) ⬇️
pkg/ipfix/ipfix_intermediate.go 51.51% <0.00%> (-37.96%) ⬇️
pkg/ipfix/ipfix_collector.go 50.00% <0.00%> (-31.82%) ⬇️
pkg/controller/networkpolicy/store/util.go 50.00% <0.00%> (-31.82%) ⬇️
...g/controller/networkpolicy/store/appliedtogroup.go 55.23% <0.00%> (-31.13%) ⬇️
pkg/controller/ipam/antrea_ipam_controller.go 43.87% <0.00%> (-30.27%) ⬇️
... and 353 more

@tnqn
Copy link
Member

tnqn commented May 10, 2022

I'm manually linking it so we will know the original PR has been backported to 1.6.

Cherry pick of #3510 on release-1.6.

@hongliangl hongliangl closed this May 10, 2022
@hongliangl hongliangl deleted the automated-cherry-pick-of-#3510-upstream-release-1.6 branch October 25, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants