Resolve reconnect issue between Agent and OVS #4091
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4091 +/- ##
==========================================
+ Coverage 65.70% 65.74% +0.04%
==========================================
Files 304 304
Lines 46604 46779 +175
==========================================
+ Hits 30621 30757 +136
- Misses 13557 13622 +65
+ Partials 2426 2400 -26
|
|
/test-all |
wenyingd
force-pushed
the
reconnect_issue
branch
3 times, most recently
from
eb5a328
to
2ac2636
Compare
pkg/agent/openflow/client.go
Outdated
| @@ -931,6 +931,11 @@ func (c *client) ReplayFlows() { | |||
| c.replayMutex.Lock() | |||
| defer c.replayMutex.Unlock() | |||
|
|
|||
| // Delete the existing groups to avoid unexpected error "OFPGMFC_GROUP_EXISTS" when replaying groups. | |||
| if err := c.bridge.DeleteAllGroups(); err != nil { | |||
There was a problem hiding this comment.
I think adding here is not enough? what about agent restart case?
Anyway I wonder if this change is relevant to the bug we want to fix here. If not, could we make this change in next release?
There was a problem hiding this comment.
we should keep this grouped with the call to c.bridge.DeleteMeterAll. They both fulfill the same purpose.
There was a problem hiding this comment.
I revert the change of deleting groups in antrea, and I would do it in another patch since the related change in ofnet is also reverted.
wenyingd
force-pushed
the
reconnect_issue
branch
from
2ac2636
to
e57ec4c
Compare
|
/test-all |
|
/test-flexible-ipam-e2e |
ofnet resolves a reconnect issue, this change is to involve the fix. Signed-off-by: wenyingd <[email protected]>
wenyingd
force-pushed
the
reconnect_issue
branch
from
e57ec4c
to
93774c0
Compare
|
Update go.mod/go.sum to refer to antrea.io/ofnet since the dependent patch is merged. All the tests are passed before this update. |
|
/test-all |
ofnet resolves a reconnect issue, this change is to involve the fix. Signed-off-by: wenyingd <[email protected]>
Bump up ofnet version
ofnet resolves a reconnect issue, this change is to involve the fix.
Fixes #4092
Signed-off-by: wenyingd [email protected]