Disable metrics api for multicluster controller and clean up configs #4101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Set the metrics binding address to 0 to disable it since we didn't provide metrics. 2. Change the health binding address port to 8080 3. Remove unused configurations. Signed-off-by: Lan Luo <[email protected]>
|
/test-multicluster-e2e |
Codecov Report
@@ Coverage Diff @@
## main #4101 +/- ##
==========================================
- Coverage 67.17% 65.12% -2.05%
==========================================
Files 298 310 +12
Lines 45465 45534 +69
==========================================
- Hits 30539 29655 -884
- Misses 12532 13496 +964
+ Partials 2394 2383 -11
|
jianjuns
approved these changes
Aug 11, 2022
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provide metrics.
Signed-off-by: Lan Luo [email protected]