Update Go to v1.19 #4106
Merged
Update Go to v1.19 #4106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
force-pushed
the
update-golang-to-v1.19
branch
from
856679b
to
f64c917
Compare
antoninbas
added
area/build-release
antoninbas
force-pushed
the
update-golang-to-v1.19
branch
from
f64c917
to
05b84b8
Compare
Codecov Report
@@ Coverage Diff @@
## main #4106 +/- ##
==========================================
+ Coverage 66.20% 66.51% +0.30%
==========================================
Files 306 304 -2
Lines 46663 47248 +585
==========================================
+ Hits 30894 31426 +532
- Misses 13366 13381 +15
- Partials 2403 2441 +38
*This pull request uses carry forward flags. Click here to find out more.
|
antoninbas
force-pushed
the
update-golang-to-v1.19
branch
3 times, most recently
from
1aeea9c
to
1927878
Compare
|
Depends on #4109 |
antoninbas
force-pushed
the
update-golang-to-v1.19
branch
from
1927878
to
6246b85
Compare
antoninbas
force-pushed
the
update-golang-to-v1.19
branch
2 times, most recently
from
b992d75
to
44ac663
Compare
Most notables changes: * we remove all uses of the io/ioutil package, which has been deprecated * gofmt now reformats doc comments (e.g., lists inside comment blocks), which is why some comments have been reformatted automatically * the codegen image has been updated to kubernetes-1.24.0-build.1 to include the updated version of Go. "go get: no longer builds or installs packages in module-aware mode, so "go get" has been replaced with "go install" in the Dockerfile. * we now use the version of Go from the root go.mod file when setting up Go in Github workflows. This will reduce the number of changes we have to do in the future when updating Go. * running "go mod tidy" with the updated Go version seems to have removed some stale entries from go.sum files. * we need to disable cgo whenever building the Octant plugin on Linux. Not quite sure how this is related to the Go version update: maybe some small change in "go build" to determine when to enable / disable cgo. Fixes antrea-io#4105 Signed-off-by: Antonin Bas <[email protected]>
Signed-off-by: Antonin Bas <[email protected]>
antoninbas
force-pushed
the
update-golang-to-v1.19
branch
from
44ac663
to
fff6009
Compare
|
/test-all |
tnqn
approved these changes
Aug 23, 2022
| @@ -274,7 +274,8 @@ func executeTests(k8s *Kubernetes, testList []*TestCase) []*TestCase { | |||
| return modifiedTestList | |||
| } | |||
|
|
|||
| /** | |||
| /* | |||
| * | |||
There was a problem hiding this comment.
out of curiosity, does the second "*" mean anything?
There was a problem hiding this comment.
it doesn't mean anything. gofmt now does some comment reformatting, and this file was updated automatically. I am ignoring this change since this whole folder (hack/netpol) should be removed pretty soon.
|
/test-e2e |
luolanzone
reviewed
Aug 24, 2022
| @@ -1 +1 @@ | |||
| 1.17 | |||
| 1.19 | |||
There was a problem hiding this comment.
Not related to this PR, but I am thinking we may use the same version from go.mod instead of this file in the future?
luolanzone
approved these changes
Aug 24, 2022
|
/test-all |
|
/test-e2e |
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
* Update Go to v1.19 Most notables changes: * we remove all uses of the io/ioutil package, which has been deprecated * gofmt now reformats doc comments (e.g., lists inside comment blocks), which is why some comments have been reformatted automatically * the codegen image has been updated to kubernetes-1.24.0-build.1 to include the updated version of Go. "go get: no longer builds or installs packages in module-aware mode, so "go get" has been replaced with "go install" in the Dockerfile. * we now use the version of Go from the root go.mod file when setting up Go in Github workflows. This will reduce the number of changes we have to do in the future when updating Go. * running "go mod tidy" with the updated Go version seems to have removed some stale entries from go.sum files. * we need to disable cgo whenever building the Octant plugin on Linux. Not quite sure how this is related to the Go version update: maybe some small change in "go build" to determine when to enable / disable cgo. Fixes antrea-io#4105 Signed-off-by: Antonin Bas <[email protected]> * Fix docker_update_base_windows.yml Signed-off-by: Antonin Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most notables changes:
which is why some comments have been reformatted automatically
include the updated version of Go. "go get: no longer builds or
installs packages in module-aware mode, so "go get" has been replaced
with "go install" in the Dockerfile.
Go in Github workflows. This will reduce the number of changes we have
to do in the future when updating Go.
removed some stale entries from go.sum files.
Linux. Not quite sure how this is related to the Go version update:
maybe some small change in "go build" to determine when to enable /
disable cgo.
Fixes #4105
Signed-off-by: Antonin Bas [email protected]