Automated cherry pick of #4154: Fix nil error issue #4173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
admission.Errored doesn't handle nil error case, it will raise a nil pointer error when there is no ClusterSet found. Fix it with a new error with error message. Refactor unit test and add a few more test cases. Signed-off-by: Lan Luo <[email protected]>
luolanzone
added
the
kind/cherry-pick
|
/test-multicluster-e2e |
Codecov Report
@@ Coverage Diff @@
## release-1.8 #4173 +/- ##
===============================================
+ Coverage 65.95% 66.54% +0.58%
===============================================
Files 304 315 +11
Lines 46593 46638 +45
===============================================
+ Hits 30732 31033 +301
+ Misses 13451 13184 -267
- Partials 2410 2421 +11
|
tnqn
approved these changes
Aug 30, 2022
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #4154 on release-1.8.
#4154: Fix nil error issue
For details on the cherry pick process, see the cherry pick requests page.