Fix ClusterSet output when status is empty #4174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4174 +/- ##
==========================================
+ Coverage 56.09% 60.42% +4.32%
==========================================
Files 371 383 +12
Lines 53327 54261 +934
==========================================
+ Hits 29913 32785 +2872
+ Misses 21071 19028 -2043
- Partials 2343 2448 +105
|
jianjuns
reviewed
Aug 30, 2022
There was a problem hiding this comment.
@luolanzone : could you provide an example output (with both empty and non-empty Status)?
|
@jianjuns the old and new output are added in the summary. |
|
@luolanzone : "Empty_ClusterSet" looks strange. Could we not set it and just show "NONE"? |
|
Sure, let me change it to NONE. |
|
Do we need to set the filed to "NONE", or antctl will print "NONE" when a filed is not set? |
|
Antctl will print "NONE" by default when a field is not set. |
luolanzone
force-pushed
the
fix-mc-clustersets
branch
from
ed488eb
to
a076b8a
Compare
|
@jianjuns, the code is updated, the new output will be like: |
|
/skip-all |
|
@luolanzone : this PR does not meet the 70% coverage target. Could you check any way to improve coverage? |
luolanzone
force-pushed
the
fix-mc-clustersets
branch
2 times, most recently
from
3403369
to
781cbe6
Compare
|
Hi @jianjuns after refactored a few codes, I added some unit tests for the |
jianjuns
previously approved these changes
Sep 1, 2022
|
@luolanzone : this PR does not reach the target coverage still. |
luolanzone
force-pushed
the
fix-mc-clustersets
branch
from
781cbe6
to
6ff567a
Compare
When a ClusterSet is created in the leader cluster, there might be no status yet, then `antctl mc get clustersets -A` will skip print the ClusterSet when the status is empty. Fix it by passing an empty status and condition. Signed-off-by: Lan Luo <[email protected]>
luolanzone
force-pushed
the
fix-mc-clustersets
branch
from
6ff567a
to
66c90f2
Compare
jianjuns
approved these changes
Sep 2, 2022
|
/skip-all |
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
After a ClusterSet is just created in the leader cluster, it might have no status yet, then `antctl mc get clustersets -A` will skip print the ClusterSet when its status is empty. Fix it by passing an empty status and condition. Signed-off-by: Lan Luo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a ClusterSet is created in the leader cluster, there might be
no status yet, then
antctl mc get clustersets -Awill skip print theClusterSet when the status is empty.
Fix it by passing an empty status and condition.
The old output:
The new output:
Signed-off-by: Lan Luo [email protected]