Automated cherry pick of #4176: Bugfix: Remove multicast group from cache when group is #4202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An issue exists in the code when calling UninstallGroups in multicast feature, that the group entry in the cache is not removed. This is because the existing code only remove group in featureService cache. To resolve the issue, rename the existing API UninstallGroup as UninstallServiceGroup, and add a new API UninstallMulticastGroup to delete multicast related groups. The new API also removes the group entry in the cache. Signed-off-by: wenyingd <[email protected]>
wenyingd
added
the
kind/cherry-pick
Codecov Report
@@ Coverage Diff @@
## release-1.8 #4202 +/- ##
===============================================
+ Coverage 65.91% 66.27% +0.35%
===============================================
Files 304 304
Lines 46593 46601 +8
===============================================
+ Hits 30712 30884 +172
+ Misses 13465 13325 -140
+ Partials 2416 2392 -24
|
|
/test-all |
tnqn
approved these changes
Sep 6, 2022
wenyingd
deleted the
automated-cherry-pick-of-#4176-upstream-release-1.8
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #4176 on release-1.8.
#4176: Bugfix: Remove multicast group from cache when group is
For details on the cherry pick process, see the cherry pick requests page.