[Flow Aggregator] Determine bucket region in S3 uploader #4237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4237 +/- ##
==========================================
- Coverage 64.36% 62.49% -1.88%
==========================================
Files 361 385 +24
Lines 52188 54471 +2283
==========================================
+ Hits 33592 34041 +449
- Misses 16147 17941 +1794
- Partials 2449 2489 +40
|
We determine the region programmatically in the S3 uploader, using the region "hint" provided in the config. Before this change, there was a mismatch between the description of the "region" config parameter and its actual implementation in the S3 uploader. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
force-pushed
the
fa-s3-uploader-determine-bucket-region
branch
from
b5b6cde
to
f9036b2
Compare
heanlan
approved these changes
Sep 19, 2022
|
/test-all |
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
) We determine the region programmatically in the S3 uploader, using the region "hint" provided in the config. Before this change, there was a mismatch between the description of the "region" config parameter and its actual implementation in the S3 uploader. Signed-off-by: Antonin Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We determine the region programmatically in the S3 uploader, using the region "hint" provided in the config.
Before this change, there was a mismatch between the description of the "region" config parameter and its actual implementation in the S3 uploader.
Signed-off-by: Antonin Bas [email protected]