-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add antcl mc commands to get/delete member token #4254
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4254 +/- ##
==========================================
+ Coverage 64.35% 65.07% +0.71%
==========================================
Files 390 405 +15
Lines 55316 55591 +275
==========================================
+ Hits 35597 36174 +577
+ Misses 17127 16805 -322
- Partials 2592 2612 +20
|
1f8cb91
to
6fbe1dc
Compare
6fbe1dc
to
3ff3a33
Compare
5c81866
to
0132533
Compare
good for review again, thanks! @luolanzone |
0132533
to
287a501
Compare
@luolanzone added Jianjun's MR part, thanks! |
@bangqipropel please don't forget to update the |
ef9e6e0
to
8bf8f2f
Compare
This pull request introduces 1 alert when merging 8bf8f2f into 549e0fb - view on LGTM.com new alerts:
|
8bf8f2f
to
c39867c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not finished review yet. Will continue.
baae576
to
956fa1d
Compare
@jianjuns comments addressed, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -0,0 +1,61 @@ | |||
// Copyright 2022 Antrea Authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The directory should be renamed as well.
956fa1d
to
9004b2d
Compare
2cf666e
to
6bc65fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
/test-all |
6bc65fc
to
722dd2c
Compare
/test-all |
/test-multicluster-e2e |
Signed-off-by: Bangqi Zhu <[email protected]>
722dd2c
to
ffff951
Compare
/test-all |
/test-multicluster-e2e |
Add 2 new commands for the users to fetch and delete Multi-cluster ClusterSet member tokens. antctl mc get membertoken: to fetch a member token, and print them out or write it in a file antctl mc delete membertoken: to delete a member token and also the RoleBinding and ServiceAccount of it. Signed-off-by: Bangqi Zhu <[email protected]>
Add 2 new commands for the users to fetch and delete Multi-cluster ClusterSet member tokens. antctl mc get membertoken: to fetch a member token, and print them out or write it in a file antctl mc delete membertoken: to delete a member token and also the RoleBinding and ServiceAccount of it. Signed-off-by: Bangqi Zhu <[email protected]>
Add 2 new commands for the users to fetch and delete tokens.
antctl mc get membertoken
: to fetch a member token, and print them out or write it in a fileantctl mc delete membertoken
: to delete a member token and also the RoleBinding and ServiceAccount of it.added the unit-test of these tokens and the relation functions
Resolve #4255