Fix route for IPv6 ClusterIPs #4297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The util function commonPrefixLen returns at most 64 bits prefix length, which leads to the calculated CIDR for IPv6 ClusterIPs being larger than actual value. For example, "aabb:ccdd::1" and "aabb:ccdd::2" should get "aabb:ccdd::/126" but got "aabb:ccdd::/64". The patch removes the 64 bits limit and changes the function name to longestCommonPrefixLen. Signed-off-by: Quan Tian <[email protected]>
tnqn
added
kind/bug
Codecov Report
@@ Coverage Diff @@
## main #4297 +/- ##
==========================================
- Coverage 63.18% 63.01% -0.18%
==========================================
Files 388 388
Lines 55229 55145 -84
==========================================
- Hits 34898 34747 -151
- Misses 17749 17831 +82
+ Partials 2582 2567 -15
|
|
/skip-all |
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
The util function commonPrefixLen returns at most 64 bits prefix length, which leads to the calculated CIDR for IPv6 ClusterIPs being larger than actual value. For example, "aabb:ccdd::1" and "aabb:ccdd::2" should get "aabb:ccdd::/126" but got "aabb:ccdd::/64". The patch removes the 64 bits limit and changes the function name to longestCommonPrefixLen. Signed-off-by: Quan Tian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The util function commonPrefixLen returns at most 64 bits prefix length, which leads to the calculated CIDR for IPv6 ClusterIPs being larger than actual value. For example, "aabb:ccdd::1" and "aabb:ccdd::2" should get "aabb:ccdd::/126" but got "aabb:ccdd::/64". The patch removes the 64 bits limit and changes the function name to longestCommonPrefixLen.
Signed-off-by: Quan Tian [email protected]