Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #4261: Enhance ACNP Service related feature #4315

Conversation

GraysonWu
Copy link
Contributor

Cherry pick of #4261 on release-1.8.

#4261: Enhance ACNP Service related feature

For details on the cherry pick process, see the cherry pick requests page.

1. Only load Service GroupID into reg when AntreaPolicy is enabled.

   Service GroupID is only used by AntreaPolicy "toServices"
   and "AppliedTo NodePort Serivces" features for now.

2. In IngressSecurityClassifierTable, only forward packet to
AntreaPolicyIngressRuleTable when AntreaPolicy is enabled and
proxyAll is enabled.

   This forward flow is only used by AntreaPolicy "AppliedTo NodePort
   Services" feature to avoid packets skip
   AntreaPolicyIngressRuleTable, where policy will be enforced, when
   the endpoint of this Service is not on current NodePort Node.

3. In ACNP appliedTo NodePort Service e2e test, change to add another
netNS to fake external network.

4. Change to use gwOFPort as inPort of reject response for some cases.

Signed-off-by: graysonwu <[email protected]>
@GraysonWu GraysonWu added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Oct 19, 2022
@GraysonWu GraysonWu requested a review from tnqn October 19, 2022 05:30
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #4315 (df5fb93) into release-1.8 (e0ae53c) will increase coverage by 0.26%.
The diff coverage is 44.44%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.8    #4315      +/-   ##
===============================================
+ Coverage        65.97%   66.23%   +0.26%     
===============================================
  Files              304      304              
  Lines            46596    46602       +6     
===============================================
+ Hits             30743    30869     +126     
+ Misses           13455    13330     -125     
- Partials          2398     2403       +5     
Flag Coverage Δ
e2e-tests 39.35% <38.88%> (?)
integration-tests 35.17% <85.71%> (+0.01%) ⬆️
kind-e2e-tests 48.54% <44.44%> (-0.38%) ⬇️
unit-tests 44.93% <11.11%> (-0.05%) ⬇️
Impacted Files Coverage Δ
pkg/agent/controller/networkpolicy/reject.go 75.86% <9.09%> (-1.64%) ⬇️
pkg/agent/openflow/client.go 73.31% <100.00%> (+2.75%) ⬆️
pkg/agent/openflow/pipeline.go 82.41% <100.00%> (-0.19%) ⬇️
pkg/agent/openflow/service.go 91.39% <100.00%> (+0.09%) ⬆️
pkg/ipfix/ipfix_process.go 81.25% <0.00%> (-18.75%) ⬇️
...nt/apiserver/handlers/serviceexternalip/handler.go 37.03% <0.00%> (-14.82%) ⬇️
pkg/controller/externalippool/controller.go 83.03% <0.00%> (-8.04%) ⬇️
pkg/ipam/poolallocator/allocator.go 49.76% <0.00%> (-5.96%) ⬇️
pkg/ovs/ovsctl/ofctl.go 46.57% <0.00%> (-5.48%) ⬇️
pkg/agent/controller/trafficcontrol/controller.go 77.95% <0.00%> (-4.41%) ⬇️
... and 33 more

@GraysonWu
Copy link
Contributor Author

/test-all

@tnqn tnqn merged commit 850cc09 into antrea-io:release-1.8 Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants