Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set no-flood config with ports for TrafficControl after restarting #4318

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

hongliangl
Copy link
Contributor

OVS ports for TrafficControl is configured with no-flood when it is created. However, after restarting OVS, no-flood config is lost for the ports. This PR adds no-flood config to OVS ports for TrafficControl when initializing Antrea Agent.

Signed-off-by: Hongliang Liu [email protected]

OVS ports for TrafficControl is configured with no-flood when it is
created. However, after restarting OVS, no-flood config is lost for
the ports. This PR adds no-flood config to OVS ports for TrafficControl
when initializing Antrea Agent.

Signed-off-by: Hongliang Liu <[email protected]>
@hongliangl hongliangl requested a review from tnqn October 19, 2022 14:52
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #4318 (a59ffc3) into main (ac70351) will decrease coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4318      +/-   ##
==========================================
- Coverage   63.16%   62.90%   -0.26%     
==========================================
  Files         388      388              
  Lines       55147    55826     +679     
==========================================
+ Hits        34833    35119     +286     
- Misses      17766    18126     +360     
- Partials     2548     2581      +33     
Flag Coverage Δ *Carryforward flag
integration-tests 34.42% <ø> (ø) Carriedforward from ac70351
kind-e2e-tests 48.15% <100.00%> (-0.40%) ⬇️
unit-tests 44.88% <66.66%> (ø) Carriedforward from ac70351

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/agent.go 59.10% <100.00%> (+8.30%) ⬆️
...g/agent/apiserver/handlers/addressgroup/handler.go 5.00% <0.00%> (-35.00%) ⬇️
...nt/apiserver/handlers/serviceexternalip/handler.go 3.70% <0.00%> (-25.93%) ⬇️
pkg/agent/controller/networkpolicy/reject.go 59.11% <0.00%> (-21.39%) ⬇️
...stry/stats/antreaclusternetworkpolicystats/rest.go 46.25% <0.00%> (-16.83%) ⬇️
...piserver/registry/stats/networkpolicystats/rest.go 41.77% <0.00%> (-16.05%) ⬇️
...er/registry/stats/antreanetworkpolicystats/rest.go 45.88% <0.00%> (-15.55%) ⬇️
pkg/agent/cniserver/ipam/ipam_service.go 76.40% <0.00%> (-12.36%) ⬇️
pkg/agent/apiserver/apiserver.go 54.86% <0.00%> (-12.16%) ⬇️
pkg/agent/apiserver/handlers/multicast/handler.go 69.76% <0.00%> (-9.31%) ⬇️
... and 40 more

@tnqn tnqn added action/release-note Indicates a PR that should be included in release notes. action/backport Indicates a PR that requires backports. labels Oct 20, 2022
@tnqn
Copy link
Member

tnqn commented Oct 20, 2022

@hongliangl please backport it to releases it applies.

@tnqn
Copy link
Member

tnqn commented Oct 20, 2022

/skip-all

@tnqn tnqn merged commit 986754c into antrea-io:main Oct 20, 2022
hongliangl added a commit to hongliangl/antrea that referenced this pull request Oct 22, 2022
…ntrea-io#4318)

OVS ports for TrafficControl is configured with no-flood when it is
created. However, after restarting OVS, no-flood config is lost for
the ports. This PR adds no-flood config to OVS ports for TrafficControl
when initializing Antrea Agent.

Signed-off-by: Hongliang Liu <[email protected]>
@hongliangl hongliangl deleted the 202210119-fix-tc-port-arp-issue branch October 24, 2022 10:38
heanlan pushed a commit to heanlan/antrea that referenced this pull request Mar 29, 2023
…ntrea-io#4318)

OVS ports for TrafficControl is configured with no-flood when it is
created. However, after restarting OVS, no-flood config is lost for
the ports. This PR adds no-flood config to OVS ports for TrafficControl
when initializing Antrea Agent.

Signed-off-by: Hongliang Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/backport Indicates a PR that requires backports. action/release-note Indicates a PR that should be included in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants