Fix possible Antrea Agent crash in dualstack mode #4480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongliangl
added
action/backport
wenyingd
reviewed
Dec 14, 2022
| @@ -75,15 +75,19 @@ func newFeaturePodConnectivity( | |||
| if ipProtocol == binding.ProtocolIP { | |||
| ctZones[ipProtocol] = CtZone | |||
| gatewayIPs[ipProtocol] = nodeConfig.GatewayConfig.IPv4 | |||
| nodeIPs[ipProtocol] = nodeConfig.NodeIPv4Addr.IP | |||
| if nodeConfig.NodeIPv4Addr != nil { | |||
There was a problem hiding this comment.
Why do we have this case?
Codecov Report
@@ Coverage Diff @@
## main #4480 +/- ##
==========================================
+ Coverage 64.58% 68.42% +3.84%
==========================================
Files 390 400 +10
Lines 57640 58306 +666
==========================================
+ Hits 37225 39897 +2672
+ Misses 17760 15633 -2127
- Partials 2655 2776 +121
|
hongliangl
force-pushed
the
20221214-fix-dualstack-tkg
branch
from
d1f5f13
to
60826ed
Compare
antoninbas
reviewed
Jan 14, 2023
pkg/agent/config/node_config_test.go
Outdated
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| ipv4Enabled, err := IsIPv4Enabled(tt.nodeConfig, tt.trafficEncapMode) | ||
| assert.Equal(t, tt.expectedErr, err) |
There was a problem hiding this comment.
use assert.EqualError, or assert.ErrorContains
When a Cluster is dualstack, it assumes that every Node is configured with both IPv4 and IPv6 addresses for Antrea Agent. However, if a Node is only configured with either IPv4 or IPv6 address, Antrea Agent will get crashed. Signed-off-by: Hongliang Liu <[email protected]>
hongliangl
force-pushed
the
20221214-fix-dualstack-tkg
branch
from
60826ed
to
9cf5b0f
Compare
|
/test-all |
antoninbas
changed the title
|
/test-ipv6-all |
|
/test-ipv6-e2e |
This was referenced Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Cluster is dualstack, it assumes that every Node is configured with both IPv4 and IPv6 addresses for Antrea Agent. However, if a Node is only configured with either IPv4 or IPv6 address, Antrea Agent will get crashed.
Signed-off-by: Hongliang Liu [email protected]