-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix windows image building error in jenkins pipeline #4697
Conversation
/test-windows-all |
1 similar comment
/test-windows-all |
/test-windows-e2e |
1 similar comment
/test-windows-e2e |
/test-windows-proxyall-e2e |
1 similar comment
/test-windows-proxyall-e2e |
/test-windows-conformance |
/test-windows-networkpolicy |
/test-windows-proxyall-e2e |
/test-windows-conformance |
1 similar comment
/test-windows-conformance |
/test-windows-proxyall-e2e |
/test-windows-conformance |
1 similar comment
/test-windows-conformance |
/test-windows-conformance |
/test-windows-conformance |
/test-windows-networkpolicy |
/test-windows-networkpolicy |
/test-windows-networkpolicy |
/test-windows-networkpolicy |
/test-windows-all |
/test-all |
/test-windows-e2e |
/test-windows-e2e |
1 similar comment
/test-windows-e2e |
/test-windows-networkpolicy |
1 similar comment
/test-windows-networkpolicy |
ci/jenkins/test.sh
Outdated
harbor_images=("sigwindowstools-kube-proxy:v1.18.0" "agnhost:2.13" "agnhost:2.13" "agnhost:2.29" "e2eteam-jessie-dnsutils:1.0" "e2eteam-pause:3.2") | ||
antrea_images=("sigwindowstools/kube-proxy:v1.18.0" "e2eteam/agnhost:2.13" "us.gcr.io/k8s-artifacts-prod/e2e-test-images/agnhost:2.13" "k8s.gcr.io/e2e-test-images/agnhost:2.29" "e2eteam/jessie-dnsutils:1.0" "e2eteam/pause:3.2") | ||
harbor_images=("sigwindowstools-kube-proxy:v1.18.0" "agnhost:2.13" "agnhost:2.13" "agnhost:2.29" "e2eteam-jessie-dnsutils:1.0" "e2eteam-jessie-dnsutils:1.0" "e2eteam-pause:3.2" "e2eteam-pause:3.2" "e2eteam-busybox:1.29-windows-amd64-1809") | ||
antrea_images=("sigwindowstools/kube-proxy:v1.18.0" "e2eteam/agnhost:2.13" "us.gcr.io/k8s-artifacts-prod/e2e-test-images/agnhost:2.13" "k8s.gcr.io/e2e-test-images/agnhost:2.29" "e2eteam/jessie-dnsutils:1.0" "gcr.io/kubernetes-e2e-test-images/jessie-dnsutils:1.0" "e2eteam/pause:3.2" "k8s.gcr.io/pause:3.2" "docker.io/library/busybox:1.29") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these changes needed? how did it work if they are not available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubernetes just declared k8s.gcr.io will not be available https://kubernetes.io/blog/2023/03/10/image-registry-redirect/ , and recently I also found some image tags like docker.io/library/busybox:1.29 are not available on windows node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old registry will still be available, but anyway it's not bad to avoid pulling the image again when we already download it from harbor registry.
DOCKER_REGISTRY is no longer needed in agent image tag. Remove it to align with containerd image tag in CI pipeline. Update more image tags which is unavailable in public repo. Fixes antrea-io#4696 Signed-off-by: Shuyang Xin <[email protected]>
/test-windows-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@XinShuYang windows-e2e and windows-networkpolicy still failed, please let me know if they are related. |
@tnqn yes they are not related to this patch. Manual test passed so we can just merge this pr to recover the windows testbed first. |
/skip-all |
DOCKER_REGISTRY is no longer needed in agent image tag. Remove it to align with containerd image tag in CI pipeline. Update more image tags which is unavailable in public repo. Fixes antrea-io#4696 Signed-off-by: Shuyang Xin <[email protected]>
DOCKER_REGISTRY is no longer needed in agent image tag. Remove it to align with containerd image tag in CI pipeline. Update more image tags which is unavailable in public repo. Fixes antrea-io#4696 Signed-off-by: Shuyang Xin <[email protected]>
DOCKER_REGISTRY is no longer needed in agent image tag. Remove it to align with containerd image tag in CI pipeline. Update more image tags which is unavailable in public repo. Fixes antrea-io#4696 Signed-off-by: Shuyang Xin <[email protected]>
DOCKER_REGISTRY is no longer needed in agent image tag. Remove it to align with containerd image tag in CI pipeline. Update more image tags which is unavailable in public repo. Fixes #4696 Signed-off-by: Shuyang Xin <[email protected]>
DOCKER_REGISTRY is no longer needed in agent image tag. Remove it to align with containerd image tag in CI pipeline. Update more image tags which is unavailable in public repo. Fixes #4696 Signed-off-by: Shuyang Xin <[email protected]>
DOCKER_REGISTRY is no longer needed in agent image tag. Remove it to align with containerd image tag in CI pipeline. Update more image tags which is unavailable in public repo. Fixes #4696 Signed-off-by: Shuyang Xin <[email protected]>
DOCKER_REGISTRY is no longer needed in agent image tag. Remove it to align with containerd image tag in CI pipeline. Update more image tags which is unavailable in public repo. Fixes antrea-io#4696 Signed-off-by: Shuyang Xin <[email protected]>
DOCKER_REGISTRY is no longer needed in agent image tag.
Remove it to align with containerd image tag in CI pipeline.
Update more image tags which is unavailable in public repo.
Fixes #4696