Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Documentation for deploying Antrea with Rancher cluster #4733

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Add Documentation for deploying Antrea with Rancher cluster #4733

merged 1 commit into from
Jul 26, 2023

Conversation

jainpulkit22
Copy link
Contributor

@jainpulkit22 jainpulkit22 commented Mar 21, 2023 •
edited
Loading

Add Documentation for deploying Antrea with Rancher cluster.

@jainpulkit22 jainpulkit22 marked this pull request as draft March 21, 2023 14:08
Atish-iaf
Atish-iaf reviewed Mar 21, 2023
View reviewed changes
docs/getting-started.md Outdated Show resolved Hide resolved
Atish-iaf
Atish-iaf reviewed Mar 21, 2023
View reviewed changes
docs/rancher.md Outdated Show resolved Hide resolved
Atish-iaf
Atish-iaf reviewed Mar 21, 2023
View reviewed changes
docs/rancher.md Outdated Show resolved Hide resolved
Atish-iaf
Atish-iaf reviewed Mar 21, 2023
View reviewed changes
docs/rancher.md Outdated Show resolved Hide resolved
rajnkamr
rajnkamr reviewed Mar 23, 2023
View reviewed changes
docs/rancher.md Outdated Show resolved Hide resolved
rajnkamr
rajnkamr reviewed Mar 23, 2023
View reviewed changes
docs/rancher.md Outdated Show resolved Hide resolved
rajnkamr
rajnkamr reviewed Mar 23, 2023
View reviewed changes
docs/getting-started.md Outdated Show resolved Hide resolved
rajnkamr
rajnkamr reviewed Mar 23, 2023
View reviewed changes
docs/rancher.md Outdated Show resolved Hide resolved
rajnkamr
rajnkamr reviewed Mar 23, 2023
View reviewed changes
Copy link
Contributor

@rajnkamr rajnkamr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add all steps with some screenshots of GUI/command executed

rajnkamr
rajnkamr reviewed Mar 28, 2023
View reviewed changes
docs/rancher.md Outdated Show resolved Hide resolved
rajnkamr
rajnkamr reviewed Mar 28, 2023
View reviewed changes
docs/rancher.md Outdated Show resolved Hide resolved
rajnkamr
rajnkamr reviewed Mar 28, 2023
View reviewed changes
Copy link
Contributor

@rajnkamr rajnkamr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments added

@luolanzone luolanzone added the kind/documentation Categorizes issue or PR as related to a documentation. label Mar 31, 2023
luolanzone
luolanzone reviewed Mar 31, 2023
View reviewed changes
docs/rancher.md Outdated Show resolved Hide resolved
docs/getting-started.md Outdated Show resolved Hide resolved
docs/rancher.md Outdated Show resolved Hide resolved
docs/rancher.md Outdated Show resolved Hide resolved
docs/rancher.md Outdated Show resolved Hide resolved
docs/rancher.md Outdated Show resolved Hide resolved
@jainpulkit22 jainpulkit22 marked this pull request as ready for review April 5, 2023 09:22
antoninbas
antoninbas reviewed Apr 5, 2023
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not check-in the PNG images in the repository. They grow the repository size irreversibly. Instead images should be uploaded to the downloads.antrea.io AWS S3 bucket (under the static/<DATE>/ prefix). @luolanzone @rajnkamr you can check with @edwardbadboy for access to the Antrea AWS account.

@rajnkamr
Copy link
Contributor

rajnkamr commented Apr 6, 2023

@jainpulkit22, to upload png images to AWS, steps to be followed are mentioned on confluence page

@jainpulkit22
Copy link
Contributor Author

Please do not check-in the PNG images in the repository. They grow the repository size irreversibly. Instead images should be uploaded to the downloads.antrea.io AWS S3 bucket (under the static/<DATE>/ prefix). @luolanzone @rajnkamr you can check with @edwardbadboy for access to the Antrea AWS account.

Made the said changes, thanks for the info @antoninbas

@jainpulkit22
Copy link
Contributor Author

@jainpulkit22, to upload png images to AWS, steps to be followed are mentioned on confluence page

done

@jainpulkit22 jainpulkit22 requested review from luolanzone and antoninbas and removed request for rajnkamr July 13, 2023 14:38
luolanzone
luolanzone reviewed Jul 17, 2023
View reviewed changes
docs/kubernetes-installers.md Outdated Show resolved Hide resolved
docs/kubernetes-installers.md Outdated Show resolved Hide resolved
@luolanzone
Copy link
Contributor

@tnqn @antoninbas could you take a look again? thanks.

antoninbas
antoninbas reviewed Jul 18, 2023
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the late review

docs/kubernetes-installers.md Outdated Show resolved Hide resolved
docs/kubernetes-installers.md Outdated Show resolved Hide resolved
@jainpulkit22 jainpulkit22 force-pushed the rancher-docs branch 2 times, most recently from a96044c to 2d4eb7c Compare July 21, 2023 11:14
antoninbas
antoninbas reviewed Jul 21, 2023
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I guess we have decided to focus on UI-based installation?

docs/kubernetes-installers.md Outdated Show resolved Hide resolved
docs/kubernetes-installers.md Outdated Show resolved Hide resolved
docs/kubernetes-installers.md Outdated Show resolved Hide resolved
docs/kubernetes-installers.md Outdated Show resolved Hide resolved
docs/kubernetes-installers.md Outdated Show resolved Hide resolved
docs/kubernetes-installers.md Outdated Show resolved Hide resolved
@jainpulkit22 jainpulkit22 force-pushed the rancher-docs branch 4 times, most recently from dfffbb2 to 191d3a1 Compare July 25, 2023 05:17
@jainpulkit22
Copy link
Contributor Author

so I guess we have decided to focus on UI-based installation?

No, I have now generalised the docs, its no more specific to UI-based installation, @antoninbas you can review it once.

@antoninbas
Copy link
Contributor

/skip-all

@antoninbas antoninbas merged commit e831074 into antrea-io:main Jul 26, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajnkamr rajnkamr rajnkamr left review comments

@Atish-iaf Atish-iaf Atish-iaf left review comments

@antoninbas antoninbas antoninbas approved these changes

@tnqn tnqn Awaiting requested review from tnqn

@luolanzone luolanzone Awaiting requested review from luolanzone

@hongliangl hongliangl Awaiting requested review from hongliangl

Assignees
No one assigned
Labels
kind/documentation Categorizes issue or PR as related to a documentation.
Projects
None yet
Milestone
Antrea v1.13 release
Development

Successfully merging this pull request may close these issues.
7 participants
@jainpulkit22 @rajnkamr @luolanzone @antoninbas @tnqn @Atish-iaf @hongliangl