Add Windows OVS image for windows ovs containerisation #4936
Conversation
|
/test-windows-containerd-e2e |
|
/test-windows-e2e |
|
@rajnkamr could you squash 3 commits into one commit? and I suppose this change depends on #4705? @XinShuYang |
Squashed 3 commits in one, ovs version no has to be updated in dependency file, otherwise #4705 remain independent @XinShuYang can confirm ! |
Thanks for the reminder, 4705 has been merged. |
tnqn
added
the
area/OS/windows
|
@rajnkamr could you check and fix Windows image build issue? https://github.com/antrea-io/antrea/actions/runs/4913939105/jobs/8774697360?pr=4936 |
|
Btw, you also need to sign-off in your commit, the DCO check is failed https://github.com/antrea-io/antrea/pull/4936/checks?check_run_id=13308968729 |
@luolanzone , this is due to build image tagged with old tag which was uploaded to registry, we need to upload new image with ovs tag, we will upload new image to registry |
This comment was marked as duplicate.
This comment was marked as duplicate.
rajnkamr
changed the title
rajnkamr
changed the title
rajnkamr
changed the title
|
/test-networkpolicy |
|
/test-conformance |
|
/test-networkpolicy |
|
/test-e2e |
|
@XinShuYang @tnqn |
build/images/ovs/Dockerfile.windows
Outdated
| powershell -Command "Start-Process -FilePath C:\vc_redist.x64.exe -ArgumentList ‘/install’,’/quiet’,’/norestart’ -Verb RunAs -Wait" | ||
|
|
||
| # Download and extract OVS | ||
| RUN curl.exe -fLo C:\ovs-${env:WIN_OVS_VERSION}-antrea.0-win64.zip https://downloads.antrea.io/ovs/ovs-${env:WIN_OVS_VERSION}-antrea.0-win64.zip; \ |
There was a problem hiding this comment.
Better to verify sha256 checksum here?
antrea/hack/windows/Install-OVS.ps1
Line 117 in af9477c
There was a problem hiding this comment.
Image creation based on download is not be a regular activity and is done only as & when new container ovs image is needed with new ovs versions and the ovs url used is also antrea specific only.
Also many places opensource urls are used in dockerfile like build/images/base-windows/Dockerfile, it might be useful to have checksum for all download cases, we can have a single github issue and handle this task separately.
|
Windows system path "C:/windows/system32" seems to be working fine |
rajnkamr
force-pushed
the
ovs
branch
2 times, most recently
from
a304481
to
153f9d2
Compare
server core image for running windows antrea ovs container. The container image has bundled ovs windows executables along with the dependencies like ssl libraries and vc pkg. bin and sbin paths are also added to windows path in the container image to facilitate various ovs executables required for debugging ovs flows Signed-off-by: Rajnish Kumar <[email protected]>
|
/skip-all |
Description-
On windows node, a new windows ovs image will be used for running ovs container, antrea agent container will use antrea-windows image. On windows node two images will need to be available i.e antrea windows ~745MB and antrea windows ovs ~ 3.6 GB.
ovs image will tagged with ovs release version