-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to clickhouse-go/v2 #5020
Conversation
1a43521
to
af26df8
Compare
Put this PR on hold as we will have to upgrade clickhouse-server version first. The current clickhouse-server is v22.6 in Theia, which is incompatible with the upgraded clickhouse-client. I'm fixing some issues in Theia while upgrading clickhouse-server. |
af26df8
to
b6818dd
Compare
We decided to remove the dependency from Antrea to Theia - by using official clickhouse-server images in e2e tests, instead of using theia/clickhouse-server images, which includes data schema management plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, only a nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I amy
b6818dd
to
afa5323
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
afa5323
to
220b323
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b26c4a0
to
a5f2c18
Compare
We upgrade Flow Aggregator to use ClickHouse go client v2 to better assist future supports. In terms of the method of creating connection, we replace DSN with OpenDB in database/sql interface. Fixes: antrea-io#4901 Signed-off-by: heanlan <[email protected]>
a5f2c18
to
4bce8b8
Compare
/test-all |
/test-e2e |
I realized the jenkins test is not testing on FlowAggregator overall, no need to trigger it. Although I don't remember when we added http://10.176.27.169:8080/job/antrea-e2e-for-pull-request/2107/consoleFull
|
|
We upgrade Flow Aggregator to use ClickHouse go client v2 to better assist future supports. In terms of the method of creating connection, we replace
DSN
withOpenDB
indatabase/sql
interface.Fixes: #4901