Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging improvements in Agent NP reconciler #5048

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Logging improvements in Agent NP reconciler #5048

merged 1 commit into from
Jun 2, 2023

Conversation

antoninbas
Copy link
Contributor

  • Switched to strctured logging
  • Change verbosity of potentially misleading Info log

Fixes #4974

@antoninbas
Logging improvements in Agent NP reconciler
5f33edd 
* Switched to strctured logging
* Change verbosity of potentially misleading Info log

Fixes antrea-io#4974

Signed-off-by: Antonin Bas <[email protected]>
@antoninbas antoninbas requested review from tnqn and Dyanngg May 26, 2023 23:10
tnqn
tnqn approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor Author

/test-all

Dyanngg
Dyanngg approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@Dyanngg Dyanngg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor Author

/test-all

1 similar comment
@antoninbas
Copy link
Contributor Author

/test-all

@antoninbas antoninbas merged commit 33a4677 into antrea-io:main Jun 2, 2023
@antoninbas antoninbas deleted the logging-improvements-in-agent-np-reconciler branch June 2, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dyanngg Dyanngg Dyanngg approved these changes

@tnqn tnqn tnqn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misleading agent log for "allow all" NetworkPolicy rule?
3 participants
@antoninbas @tnqn @Dyanngg