Stop checking upgrades for clickhouse-go/v2 #5086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luolanzone
reviewed
Jun 6, 2023
| @@ -16,6 +16,7 @@ updates: | |||
| - dependency-name: "github.com/aws/*" # updates are too frequent | |||
| - dependency-name: "antrea.io/ofnet" | |||
| - dependency-name: "antrea.io/libOpenflow" | |||
| - dependency-name: "github.com/ClickHouse/clickhouse-go/v2" # auto-upgrade involves dependency conflicts | |||
There was a problem hiding this comment.
I think /v2 can be removed? @antoninbas
There was a problem hiding this comment.
I am not sure actually. Because of how it works in Go, the v2 is actually part of the module name: https://github.com/ClickHouse/clickhouse-go/blob/f5051e3d27e9f795670d76b203717958f0f1a536/go.mod#L1
There isn't exactly a lot of information in the dependabot documentation...
If we do remove it, we may need a wildcard?
I am happy with keeping the dependency name as it is. I feel like we could add update-types: ["version-update:semver-major", "version-update:semver-minor"] so we still potentially get patches. ("version-update:semver-major" would not really have an effect here).
We stop auto-upgrade from Dependabot on the package as it will involve dependency conflicts. We should upgrade the package manually when needed. Signed-off-by: heanlan <[email protected]>
heanlan
force-pushed
the
add-ch-to-dependabot
branch
from
025d842
to
83f2d49
Compare
antoninbas
approved these changes
Jun 6, 2023
antoninbas
approved these changes
Jun 6, 2023
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We stop auto-upgrade from Dependabot on the package as it will involve dependency conflicts. We should upgrade the package manually when needed.