Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add apiVersion and kind for unstructured objects in "antctl mc" code #5138

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Add apiVersion and kind for unstructured objects in "antctl mc" code #5138

merged 1 commit into from
Jun 29, 2023

Conversation

luolanzone
Copy link
Contributor

@luolanzone luolanzone commented Jun 16, 2023 •
edited by jianjuns
Loading

Fix a deletion error during rollback after an antctl mc command failed.

Failed to delete  kube-system/test-clusterset: Object 'Kind' is missing in
'unstructured object has no kind'

apiVersion and kind are required fields in unstructured object to do deletion,
but DefaultUnstructuredConverter.ToUnstructured will not convert them
automatically.

@luolanzone luolanzone added the area/multi-cluster Issues or PRs related to multi cluster. label Jun 16, 2023
@jianjuns jianjuns changed the title Add apiVersion and kind for unstructured objects Add apiVersion and kind for unstructured objects in "antctl mc" code Jun 20, 2023
@jianjuns
Copy link
Contributor

/test-multicluster-e2e

1 similar comment
@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

@jianjuns
Copy link
Contributor

@luolanzone : could we fix the Kind tests?

@luolanzone
Add apiVersion and kind for unstructured objects
b0aad6f 
Fix a deletion error during rollback if any `antctl mc` command is failed.

```
Failed to delete  kube-system/test-clusterset: Object 'Kind' is missing in
'unstructured object has no kind'
```

apiVersion and kind are required fields in unstructured object to do
deletion but `DefaultUnstructuredConverter.ToUnstructured` will not
convert them automatically.

Signed-off-by: Lan Luo <[email protected]>
@luolanzone
Copy link
Contributor Author

@jianjuns the kind tests are all passed after a force push. Could you help to move forward? Thanks.
Btw, the test images are uploaded via upload-artifact action, the workflow defines retention-days as 1 day, so rerun will always fail if job is re-triggered after 24 hours.

@jianjuns
Copy link
Contributor

/skip-all

@jianjuns
Copy link
Contributor

/test-multicluster-e2e

@jianjuns
Copy link
Contributor

/test-multicluster-e2e keeps failing. It should be irrelevant, but could you check? @luolanzone

@jianjuns
Copy link
Contributor

/test-multicluster-e2e

1 similar comment
@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

@luolanzone
Copy link
Contributor Author

@jianjuns the failure is irrelevant with this PR, I was upgrading Kind in the MC testbed for the PR #5179.
The testbed issue has been fixed and the new triggered test are passed now. Can you help to merge this? Thanks.

@jianjuns jianjuns merged commit dff1efd into antrea-io:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianjuns jianjuns jianjuns approved these changes

@hjiajing hjiajing Awaiting requested review from hjiajing

Assignees
No one assigned
Labels
area/multi-cluster Issues or PRs related to multi cluster.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luolanzone @jianjuns