[e2e] Make probe outputs more informative #5140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luolanzone
added
the
area/test/e2e
GraysonWu
reviewed
Jun 20, 2023
tnqn
force-pushed
the
improve-probe-log
branch
2 times, most recently
from
faef0de
to
18fc1cb
Compare
GraysonWu
previously approved these changes
Jun 21, 2023
"agnhost connect" outputs nothing when it succeeds. The current probe output like below can't tell which attemp succeeded and if it really succeeded: ``` TIMEOUT TIMEOUT ``` We output "CONNECTED" when a connection succeeds and prepend a sequence number for each attempt, to make the result more informative. An example output: ``` 1: CONNECTED 2: TIMEOUT 3: TIMEOUT ``` Signed-off-by: Quan Tian <[email protected]>
The failure has been fixed |
GraysonWu
approved these changes
Jun 26, 2023
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"agnhost connect" outputs nothing when it succeeds. The current probe output like below can't tell which attemp succeeded and if it really succeeded:
We output "CONNECTED" when a connection succeeds and prepend a sequence number for each attempt, to make the result more informative. An example output:
For #5139