Upgrade Tier API version to v1beta1 #5172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luolanzone
added
api-review
luolanzone
reviewed
Jun 27, 2023
GraysonWu
force-pushed
the
tier-upgrade
branch
2 times, most recently
from
837bc64
to
7defff1
Compare
GraysonWu
force-pushed
the
tier-upgrade
branch
2 times, most recently
from
1bfe6a5
to
874b1bf
Compare
luolanzone
previously approved these changes
Jul 7, 2023
There was a problem hiding this comment.
LGTM overall, @GraysonWu could you add some descriptions like Note: Given the limited nature of the changes between the 2 API versions, the default None conversion strategy can be used. to highlight that we will use the None conversion strategy.
antoninbas
previously approved these changes
Jul 13, 2023
There was a problem hiding this comment.
LGTM - I confirmed with @GraysonWu that there is no actual change to the API, just a version bump
|
/test-all |
|
/test-multicluster-e2e |
Note: Given the limited nature of the changes between the 2 API versions, the default None conversion strategy can be used. Signed-off-by: graysonwu <[email protected]>
|
/test-multicluster-e2e |
tnqn
reviewed
Jul 14, 2023
1. Fix MC E2E test failures 2. Change api.md Signed-off-by: graysonwu <[email protected]>
|
/test-all |
antoninbas
approved these changes
Jul 14, 2023
Closed
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the limited nature of the changes between the 2 API
versions, using the None conversion strategy.