-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote ExternalIPPool API to v1beta1 #5176
Promote ExternalIPPool API to v1beta1 #5176
Conversation
0cb2e0f
to
ed933bb
Compare
ed933bb
to
aa33db1
Compare
aa33db1
to
1a1683e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
Signed-off-by: Hongliang Liu <[email protected]>
1a1683e
to
53dc300
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall @hongliangl please address the latest comment of api.md, so we can move forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-all |
type: array | ||
matchLabels: | ||
additionalProperties: | ||
type: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been merged, but I wonder why we use a specific pattern
above for label values, but not here?
@tnqn @hongliangl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know additionalProperties
can support pattern
attribute, didn't see such example in docs. But I just took a try, and pattern
works for additionalProperties
too.
@hongliangl could you follow up with an enhancement PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will do.
Signed-off-by: Hongliang Liu <[email protected]>
Signed-off-by: Hongliang Liu <[email protected]>
Signed-off-by: Hongliang Liu <[email protected]>
No description provided.