Consume Topology Mode Annotation for AntreaProxy #5241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New service.kubernetes.io/topology-mode annotation has been introduced as a replacement for the service.kubernetes.io/topology-aware-hints annotation. The service.kubernetes.io/topology-aware-hints annotation has been deprecated in K8s 1.27. This change let AntreaProxy consume both annotations to support topology aware routing. Fixes: antrea-io#5122 Signed-off-by: Mengdie Song <[email protected]>
tnqn
reviewed
Jul 14, 2023
Comment on lines
+237
to
+239
| info.hintsAnnotation, ok = service.Annotations[v1.AnnotationTopologyAwareHints] | ||
| if !ok { | ||
| info.hintsAnnotation, _ = service.Annotations["service.kubernetes.io/topology-mode"] |
There was a problem hiding this comment.
I think the new annotation should be preferred when both annotations exist.
There was a problem hiding this comment.
Ignore the comment, I see you are following the same behavior as kube-proxy.
tnqn
added
area/proxy
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New service.kubernetes.io/topology-mode annotation has been introduced as a replacement for the service.kubernetes.io/topology-aware-hints annotation. The service.kubernetes.io/topology-aware-hints annotation has been deprecated in K8s 1.27.
This change let AntreaProxy consume both annotations to support topology aware routing.
Fixes: #5122