Document LoadBalancerMode related feature gate and configuration #5251

tnqn · 2023-07-14T16:10:13Z

antoninbas

minor comments and suggestions, otherwise lgtm

antoninbas · 2023-07-14T18:26:01Z

docs/antrea-proxy.md

+Nodes. Currently, it has two options: nat (default) and dsr.
+
+* In NAT mode, external traffic is SNAT'd when it's load balanced across Nodes
+to ensure symmetric path. It's the default and the most applicable mode.


Suggested change

to ensure symmetric path. It's the default and the most applicable mode.

to ensure symmetric paths. It's the default and the most general mode.

antoninbas · 2023-07-14T18:27:47Z

docs/antrea-proxy.md

+* In DSR mode, external traffic is never SNAT'd and backend Pods running on
+Nodes that are not the ingress Node can reply to clients directly, bypassing
+the ingress Node. Therefore, traffic in DSR mode usually has lower latency,
+higher output bandwidth, and preserved client IP. Currently, it is applicable


Suggested change

higher output bandwidth, and preserved client IP. Currently, it is applicable

higher throughput, and can preserve client IP. Currently, it is only applicable

antoninbas · 2023-07-14T18:29:19Z

docs/antrea-proxy.md

+Nodes that are not the ingress Node can reply to clients directly, bypassing
+the ingress Node. Therefore, traffic in DSR mode usually has lower latency,
+higher output bandwidth, and preserved client IP. Currently, it is applicable
+to Linux Nodes, encap mode, and IPv4 cluster. The feature gate


s/cluster/clusters

antoninbas · 2023-07-14T18:29:37Z

docs/antrea-proxy.md

+`LoadBalancerModeDSR` must be enabled to use this mode for any Service.
+
+You can make the following changes to the `antrea-config` ConfigMap to specify
+load balancer mode for all Services:


a load balancer mode

changed to "the default load balancer mode".

antoninbas · 2023-07-14T18:30:45Z

docs/feature-gates.md

+mode determines how external traffic destined to LoadBalancerIPs and ExternalIPs of Services is processed when it's load
+balanced across Nodes. In DSR mode, external traffic is never SNAT'd and backend Pods running on Nodes that are not the
+ingress Node can reply to clients directly, bypassing the ingress Node. Therefore, traffic in DSR mode usually has lower
+latency, higher output bandwidth, and preserved client IP. It's only meaningful to use feature when AntreaProxy is


same suggestion as above

antoninbas · 2023-07-14T18:31:38Z

docs/feature-gates.md

+
+#### Requirements for this Feature
+
+- `AntreaProxy` is enabled.


I feel like there are more requirements, which we typically list here:

AntreaProxy with proxyAll is enabled.

IPv4 only

Linux Nodes only

Encap mode only

jianjuns · 2023-07-14T18:27:04Z

docs/antrea-proxy.md

+can be used to specify how you want AntreaProxy to handle external traffic
+destined to LoadBalancerIPs and ExternalIPs of Services. Specifically, the mode
+determines how external traffic is processed when it's load balanced across
+Nodes. Currently, it has two options: nat (default) and dsr.


nat (defualt) and dsr?

sorry, what do you mean?

I meant add "`" around "nat" and "drs".

docs/antrea-proxy.md

docs/feature-gates.md

docs/antrea-proxy.md

docs/feature-gates.md

antoninbas

a couple nits, LGTM

docs/antrea-proxy.md

antoninbas · 2023-07-18T20:44:23Z

docs/antrea-proxy.md

+
+* In DSR mode, external traffic is never SNAT'd and backend Pods running on
+Nodes that are not the ingress Node can reply to clients directly, bypassing
+the ingress Node. Therefore, DSR mode can preserve client IP of requests, and


nit: the client IP

antoninbas · 2023-07-18T20:44:35Z

docs/antrea-proxy.md

@@ -218,3 +274,8 @@ There are two important prerequisites for this feature:
  greater than 65535 seconds will be truncated and the Antrea Agent will log a
  warning. [We do not intend to address this
  limitation](https://github.com/antrea-io/antrea/issues/1578).
+* Due to the use of the "learn" action on the implementation of DSR mode, the


antoninbas · 2023-07-19T16:53:56Z

/skip-all

Signed-off-by: Quan Tian <[email protected]>

tnqn · 2023-07-20T08:53:17Z

@antoninbas just removed an empty in the latest update.

antoninbas · 2023-07-20T17:15:18Z

/skip-all

tnqn added kind/documentation Categorizes issue or PR as related to a documentation. area/proxy Issues or PRs related to proxy functions in Antrea labels Jul 14, 2023

tnqn added this to the Antrea v1.13 release milestone Jul 14, 2023

tnqn requested review from antoninbas and jianjuns July 14, 2023 16:10

antoninbas reviewed Jul 14, 2023

View reviewed changes

jianjuns reviewed Jul 14, 2023

View reviewed changes

luolanzone reviewed Jul 17, 2023

View reviewed changes

docs/antrea-proxy.md Outdated Show resolved Hide resolved

docs/feature-gates.md Outdated Show resolved Hide resolved

tnqn force-pushed the doc-dsr branch 2 times, most recently from 021ad52 to 0e3792a Compare July 18, 2023 14:18

antoninbas previously approved these changes Jul 18, 2023

View reviewed changes

tnqn dismissed antoninbas’s stale review via ad45370 July 19, 2023 09:38

tnqn force-pushed the doc-dsr branch from 0e3792a to ad45370 Compare July 19, 2023 09:38

antoninbas previously approved these changes Jul 19, 2023

View reviewed changes

Document LoadBalancerMode related feature gate and configuration

f26fb86

Signed-off-by: Quan Tian <[email protected]>

tnqn dismissed antoninbas’s stale review via f26fb86 July 20, 2023 08:52

tnqn force-pushed the doc-dsr branch from ad45370 to f26fb86 Compare July 20, 2023 08:52

antoninbas approved these changes Jul 20, 2023

View reviewed changes

antoninbas merged commit f96efa2 into antrea-io:main Jul 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Document LoadBalancerMode related feature gate and configuration #5251

Document LoadBalancerMode related feature gate and configuration #5251

tnqn commented Jul 14, 2023

antoninbas left a comment

antoninbas Jul 14, 2023

tnqn Jul 17, 2023

antoninbas Jul 14, 2023

tnqn Jul 17, 2023

antoninbas Jul 14, 2023

tnqn Jul 17, 2023

antoninbas Jul 14, 2023

tnqn Jul 17, 2023

antoninbas Jul 14, 2023

tnqn Jul 17, 2023

antoninbas Jul 14, 2023

tnqn Jul 17, 2023

jianjuns Jul 14, 2023

tnqn Jul 17, 2023

jianjuns Jul 17, 2023

tnqn Jul 18, 2023

antoninbas left a comment

antoninbas Jul 18, 2023

tnqn Jul 19, 2023

antoninbas Jul 18, 2023

tnqn Jul 19, 2023

antoninbas commented Jul 19, 2023

tnqn commented Jul 20, 2023

antoninbas commented Jul 20, 2023

	to ensure symmetric path. It's the default and the most applicable mode.
	to ensure symmetric paths. It's the default and the most general mode.

	higher output bandwidth, and preserved client IP. Currently, it is applicable
	higher throughput, and can preserve client IP. Currently, it is only applicable


		#### Requirements for this Feature

		- `AntreaProxy` is enabled.

Document LoadBalancerMode related feature gate and configuration #5251

Document LoadBalancerMode related feature gate and configuration #5251

Conversation

tnqn commented Jul 14, 2023

antoninbas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

antoninbas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

antoninbas commented Jul 19, 2023

tnqn commented Jul 20, 2023

antoninbas commented Jul 20, 2023