Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use antrea-windows image for antrea-ovs container #5305

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Use antrea-windows image for antrea-ovs container #5305

merged 1 commit into from
Jul 28, 2023

Conversation

Atish-iaf
Copy link
Contributor

@Atish-iaf Atish-iaf commented Jul 24, 2023 •
edited
Loading

For #4952

@Atish-iaf
Copy link
Contributor Author

/test-windows-containerd-e2e

@Atish-iaf Atish-iaf mentioned this pull request Jul 24, 2023
Merged
@Atish-iaf Atish-iaf changed the title [Not4Review] Test Windows OVS in container Use antrea-windows image for antrea-ovs container Jul 26, 2023
@Atish-iaf
Copy link
Contributor Author

/test-windows-containerd-e2e

@Atish-iaf
Copy link
Contributor Author

/test-windows-containerd-conformance
/test-windows-containerd-networkpolicy

@Atish-iaf Atish-iaf marked this pull request as ready for review July 26, 2023 12:47
@Atish-iaf Atish-iaf requested a review from rajnkamr July 26, 2023 12:48
@Atish-iaf Atish-iaf added the area/OS/windows Issues or PRs related to the Windows operating system. label Jul 26, 2023
@tnqn tnqn added this to the Antrea v1.13 release milestone Jul 26, 2023
@Atish-iaf
Copy link
Contributor Author

/test-windows-containerd-e2e

@Atish-iaf
Copy link
Contributor Author

/test-windows-containerd-e2e
/test-windows-containerd-conformance
/test-windows-containerd-networkpolicy

tnqn
tnqn previously approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume the change made to test.sh needs to be reverted before merge?

@Atish-iaf
Copy link
Contributor Author

LGTM, I assume the change made to test.sh needs to be reverted before merge?

Yes,once the ongoing tests pass, i will revert the changes made in test.sh and then we can run tests for antrea-windows-containerd as well and then merge.

@Atish-iaf
Copy link
Contributor Author

/test-windows-containerd-e2e

2 similar comments
@Atish-iaf
Copy link
Contributor Author

/test-windows-containerd-e2e

@Atish-iaf
Copy link
Contributor Author

/test-windows-containerd-e2e

@Atish-iaf
Copy link
Contributor Author

/test-windows-containerd-e2e
/test-windows-containerd-conformance
/test-windows-containerd-networkpolicy

@Atish-iaf
Copy link
Contributor Author

/test-windows-containerd-e2e

1 similar comment
@Atish-iaf
Copy link
Contributor Author

/test-windows-containerd-e2e

@Atish-iaf
Copy link
Contributor Author

/test-windows-containerd-e2e
/test-windows-containerd-conformance

wenyingd
wenyingd approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@wenyingd wenyingd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Atish-iaf
Copy link
Contributor Author

/test-windows-containerd-conformance

@Atish-iaf
Copy link
Contributor Author

/test-windows-containerd-conformance

1 similar comment
@Atish-iaf
Copy link
Contributor Author

/test-windows-containerd-conformance

@Atish-iaf Atish-iaf mentioned this pull request Jul 28, 2023
Merged
@Atish-iaf Atish-iaf requested a review from tnqn July 28, 2023 04:56
@tnqn
Copy link
Member

tnqn commented Jul 28, 2023

/skip-all

@tnqn tnqn merged commit f457435 into antrea-io:main Jul 28, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnqn tnqn tnqn approved these changes

@wenyingd wenyingd wenyingd approved these changes

@XinShuYang XinShuYang Awaiting requested review from XinShuYang

@rajnkamr rajnkamr Awaiting requested review from rajnkamr

Assignees
No one assigned
Labels
area/OS/windows Issues or PRs related to the Windows operating system.
Projects
None yet
Milestone
Antrea v1.13 release
Development

Successfully merging this pull request may close these issues.
4 participants
@Atish-iaf @tnqn @wenyingd @XinShuYang