[Multicast] Remove NetworkPolicyStats dependency of MulticastGroup API #5367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-multicast-e2e |
tnqn
reviewed
Aug 8, 2023
| @@ -91,20 +91,29 @@ func TestRESTList(t *testing.T) { | |||
| networkPolicyStatsEnabled bool | |||
There was a problem hiding this comment.
I think we should remove this factor from tests too.
There was a problem hiding this comment.
If we remove this factor, we cannot test the result of MulticastGroup API is irrelevant to the NetworkPolicyStats feature because we have already asserted it. Not sure if this is good practice. Could you explain more?
There was a problem hiding this comment.
Then the condition would be kept forever? Could it be confusing in the future?
Fixes antrea-io#5329 Signed-off-by: ceclinux <[email protected]>
ceclinux
force-pushed
the
mcast-no-depend-on-networkpolicystats
branch
from
56bbe4e
to
e926842
Compare
antoninbas
approved these changes
Aug 10, 2023
antoninbas
added
action/backport
|
@ceclinux could you backport this (ideally to 1.13, 1.12 and 1.11)? |
|
/test-all |
sure |
|
/test-all |
|
/test-conformance |
|
/test-networkpolicy |
This was referenced Aug 16, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5329