Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.13.1 #5430

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Release 1.13.1 #5430

merged 2 commits into from
Sep 11, 2023

Conversation

luolanzone
Copy link
Contributor

No description provided.

Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luolanzone : could we include this one to 1.13.1: #5380. It is needed by public cloud. @qiyueyao

CHANGELOG/CHANGELOG-1.13.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-1.13.md Outdated Show resolved Hide resolved
CHANGELOG/CHANGELOG-1.13.md Outdated Show resolved Hide resolved
@antoninbas
Copy link
Contributor

@luolanzone : could we include this one to 1.13.1: #5380. It is needed by public cloud. @qiyueyao

That's a brand new API, we should not include it IMO. If Nephe needs it, they can temporarily use a commit sha from the main branch.

@jianjuns
Copy link
Contributor

That's a brand new API, we should not include it IMO. If Nephe needs it, they can temporarily use a commit sha from the main branch.

So, all new API must wait for a new major release?

@antoninbas
Copy link
Contributor

So, all new API must wait for a new major release?

All new APIs and new features should wait for a new minor release. It also makes it easier to track which versions have which features / APIs.

@antoninbas
Copy link
Contributor

@luolanzone a new patch was added to the release: #5428

@antoninbas
Copy link
Contributor

@luolanzone and another one: #5432

@luolanzone luolanzone force-pushed the release-1.13.1-notes branch 2 times, most recently from 0bdda41 to 3a946bf Compare August 24, 2023 02:20
@luolanzone
Copy link
Contributor Author

@antoninbas two PRs #5392 #5413 are added.

@tnqn
Copy link
Member

tnqn commented Aug 24, 2023

That's a brand new API, we should not include it IMO. If Nephe needs it, they can temporarily use a commit sha from the main branch.

So, all new API must wait for a new major release?

If they really need an image and a tag, we could generate a 1.14 pre-release based on main branch. It also looks a bit confusing to me to backport a new API in a patch release unless it's required for critical bug or security stuff.

@luolanzone
Copy link
Contributor Author

/test-whole-conformance
/skip-conformance
/test-networkpolicy
/test-e2e
/test-flexible-ipam-e2e
/test-multicluster-e2e
/test-multicast-e2e
/test-windows-all
/test-ipv6-all
/test-ipv6-only-all
/test-vm-e2e

@luolanzone
Copy link
Contributor Author

/test-flexible-ipam-e2e
/test-windows-containerd-networkpolicy

@luolanzone
Copy link
Contributor Author

/test-windows-proxyall-e2e

@luolanzone
Copy link
Contributor Author

/test-windows-containerd-networkpolicy

@luolanzone
Copy link
Contributor Author

/test-windows-proxyall-e2e

2 similar comments
@luolanzone
Copy link
Contributor Author

/test-windows-proxyall-e2e

@luolanzone
Copy link
Contributor Author

/test-windows-proxyall-e2e

@luolanzone
Copy link
Contributor Author

/test-windows-proxyall-e2e
/test-flexible-ipam-e2e

@luolanzone
Copy link
Contributor Author

The testbed for test-windows-proxyall-e2e is broken, @XinShuYang is working on this.

@xliuxu
Copy link
Contributor

xliuxu commented Aug 25, 2023

@luolanzone maybe we can also include #5434 in 1.13.1?

@luolanzone luolanzone force-pushed the release-1.13.1-notes branch 2 times, most recently from 9d9b4a7 to c37f5af Compare September 1, 2023 10:15
@luolanzone
Copy link
Contributor Author

/test-whole-conformance
/skip-conformance
/test-networkpolicy
/test-e2e
/test-flexible-ipam-e2e
/test-multicluster-e2e
/test-multicast-e2e
/test-windows-all
/test-ipv6-all
/test-ipv6-only-all
/test-vm-e2e

@luolanzone
Copy link
Contributor Author

/test-windows-containerd-conformance
/test-windows-containerd-networkpolicy
/test-windows-e2e
/test-multicluster-e2e
/test-multicast-e2e
/test-flexible-ipam-e2e

@luolanzone
Copy link
Contributor Author

/test-windows-proxyall-e2e

@luolanzone
Copy link
Contributor Author

There is a known flexible-ipam issue tracked by #5451 , we may ignore the flexible-ipam e2e tests.

@luolanzone
Copy link
Contributor Author

/test-windows-containerd-networkpolicy
/test-windows-proxyall-e2e

@XinShuYang
Copy link
Contributor

/test-windows-containerd-networkpolicy

@XinShuYang
Copy link
Contributor

@luolanzone We can skip windows docker jobs including windows-proxyall-e2e job in 1.13 release since the testbed is running on k8s 1.21.

@tnqn
Copy link
Member

tnqn commented Sep 5, 2023

/test-multicast-e2e

@tnqn
Copy link
Member

tnqn commented Sep 5, 2023

/skip-conformance

@luolanzone
Copy link
Contributor Author

The multicluster e2e is passed, but the status of github is pending, we can ignore the issue for now.
@XinShuYang do you have any idea why the multicluster job didn't report the status to github?

@luolanzone
Copy link
Contributor Author

Looks like there are two multi-cluster e2e jobs triggered, the one in public jenkins is in pending status, I suppose we can disable it? @XinShuYang @hjiajing

@XinShuYang
Copy link
Contributor

@luolanzone After discussing with @hjiajing, I have disabled multicluster job on public jenkins, so now it's only available on lab jenkins.

@tnqn
Copy link
Member

tnqn commented Sep 5, 2023

@luolanzone I have ran all cloud tests and they all passed. Please address Jianjun's comment and update the date then we can proceed. We don't need to rerun succeeded jobs.

@luolanzone luolanzone force-pushed the release-1.13.1-notes branch 2 times, most recently from 13bdd4f to 5df4aaf Compare September 6, 2023 01:26
@luolanzone
Copy link
Contributor Author

@tnqn comment addressed and the date is updated, please help to move forward. Thanks.

@luolanzone
Copy link
Contributor Author

@tnqn I updated the date to Sep 11 as the release date, no other changes.

@tnqn tnqn merged commit ea06f02 into antrea-io:release-1.13 Sep 11, 2023
37 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants