Handle stale LabelIdentities created for empty Pod labels correctly after upgrade #5449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter upgrade This is a follow-up on PR antrea-io#5404 which intends to address issue antrea-io#5403. In upgrade cases, Antrea controller will still receive LabelIdentity add events for LabelIdentities created by previous controller, which it needs to handle correctly. Also, the stale controller logic needs to be updated to ensure that LabelIdentities created with old normalization method are cleaned up after upgrade. Signed-off-by: Dyanngg <[email protected]>
|
/test-multicluster-e2e |
This was referenced Aug 29, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on PR #5404 which intends to address issue #5403.
In upgrade cases, Antrea controller will still receive LabelIdentity add events for LabelIdentities created by previous controller, which it needs to handle correctly. Also, the stale controller logic needs to be updated to ensure that LabelIdentities created with old normalization method are cleaned up after upgrade.