Fix burst of PacketInQueue #5456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnqn
added
area/network-policy
2 tasks
The burst was not effective because the number of tokens was hardcoded to 1, leading to 10ms delay when processing every successive DNS response. For example, in some scenario it takes a client 10 DNS queries to get a valid DNS response, the later 9 DNS responses would be delayed 90ms in total. This affected the DNS resolution delay when a Pod has any FQDN policy applied. This commit fixes the burst setting of the PacketInQueue. The connection time of accessing a FQDN is reduced from 134ms to 41ms according to my test. Signed-off-by: Quan Tian <[email protected]>
tnqn
force-pushed
the
fix-rate-limiting
branch
from
312416a
to
30cec19
Compare
jianjuns
approved these changes
Aug 30, 2023
|
/test-all |
This was referenced Aug 31, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The burst was not effective because the number of tokens was hardcoded to 1, leading to 10ms delay when processing every successive DNS response. For example, in some scenario it takes a client 10 DNS queries to get a valid DNS response, the later 9 DNS responses would be delayed 90ms in total. This affected the DNS resolution delay when a Pod has any FQDN policy applied.
This commit fixes the burst setting of the PacketInQueue. The connection time of accessing a FQDN is reduced from 134ms to 41ms according to my test.
For #5446