Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Append an ending message in the test output #5507

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Sep 20, 2023

To differentiate whether the output gets cut or the agnhost command didn't output anything.

For #5139

To differentiate whether the output gets cut or the agnhost command
didn't output anything.

Signed-off-by: Quan Tian <[email protected]>
@tnqn tnqn marked this pull request as ready for review October 24, 2023 04:16
@tnqn
Copy link
Member Author

tnqn commented Oct 24, 2023

I haven't figured out why but none of the NetworkPolicy have ever failed a single time in 15 runs after appending a message to the end of the result. Perhaps this somehow fixes the underlying issue in the clientset lib?
Promote the PR as an official PR as suggested by @antoninbas
cc @Dyanngg @GraysonWu

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to merge it IMO, even if we don't really understand why it helps. What matters here is to reduce / eliminate the flakiness. We can keep track of test failures over time and see what happens.

Really strange that we only see failures in TestGroupNoK8sNP, when all NP tests are pretty much built the same way and use the same functions.

@Dyanngg
Copy link
Contributor

Dyanngg commented Oct 24, 2023

Really strange that we only see failures in TestGroupNoK8sNP, when all NP tests are pretty much built the same way and use the same functions.

This is because TestGroupNoK8sNP has 60 tests in it while there are only around 5 other cases that test traffic outside of this test group

@antoninbas
Copy link
Contributor

Really strange that we only see failures in TestGroupNoK8sNP, when all NP tests are pretty much built the same way and use the same functions.

This is because TestGroupNoK8sNP has 60 tests in it while there are only around 5 other cases that test traffic outside of this test group

Makes sense

@tnqn
Copy link
Member Author

tnqn commented Oct 24, 2023

/test-e2e
/skip-conformance
/skip-networkpolicy

@tnqn tnqn merged commit e05add4 into antrea-io:main Oct 24, 2023
47 of 55 checks passed
@tnqn tnqn deleted the improve-error-output branch October 24, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants